MudPopover: Fix Z-Index edge cases#10735
Merged
Merged
Conversation
Member
|
you can update the branch to get rid of the |
danielchalmers
requested changes
Jan 28, 2025
Member
There was a problem hiding this comment.
When launching the test viewer I get:
TypeError: Cannot read properties of undefined (reading 'getAttribute')
Stack trace:
> at MudPopover.callback (https://localhost:44355/_content/MudBlazor/MudBlazor.min.js:220:138)
at
const tickValue=parseInt(popoverContentNode.getAttribute('data-ticks'))
EDIT: Not fixed with full rebuild + cleared cache.
ScarletKuro
reviewed
Jan 28, 2025
Contributor
Author
Added some logic to prevent this in future. |
|
danielchalmers
left a comment
Member
There was a problem hiding this comment.
MudSelect seems to flicker on mouse click
Video.mp4
Contributor
Author
yeah that's the mudselect bug, I thought that fix was already merged? mudselect.mp4 |
Member
|
Will wait on #10740 merge to re-review |
danielchalmers
approved these changes
Jan 30, 2025
ScarletKuro
approved these changes
Jan 30, 2025
7 tasks
This was referenced Aug 18, 2025
This was referenced Oct 5, 2025
This was referenced Dec 29, 2025
This was referenced Jan 9, 2026
This was referenced Feb 23, 2026
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Resolves #10723 by recalculating MudOverlay position when a nested popover is closed.
Resolves #10727 by not allowing default css value to lower the js z-index value assigned.
How Has This Been Tested?
Visually, Unit tests still pass
Type of Changes
Checklist
dev).