Skip to content

MudPopover: Fix Z-Index edge cases#10735

Merged
danielchalmers merged 15 commits into
MudBlazor:devfrom
versile2:fix/10723
Jan 30, 2025
Merged

MudPopover: Fix Z-Index edge cases#10735
danielchalmers merged 15 commits into
MudBlazor:devfrom
versile2:fix/10723

Conversation

@versile2

Copy link
Copy Markdown
Contributor

Description

Resolves #10723 by recalculating MudOverlay position when a nested popover is closed.
Resolves #10727 by not allowing default css value to lower the js z-index value assigned.

How Has This Been Tested?

Visually, Unit tests still pass

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions Bot added the bug Unexpected behavior or functionality not working as intended label Jan 27, 2025
@ScarletKuro

Copy link
Copy Markdown
Member

you can update the branch to get rid of the DateRangePicker_Preset_No_Timestamp test fail.

@versile2 versile2 marked this pull request as ready for review January 27, 2025 19:38
@danielchalmers danielchalmers changed the title Z-Index Fixes MudPopover: Fix Z-Index edge cases Jan 28, 2025

@danielchalmers danielchalmers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When launching the test viewer I get:

TypeError: Cannot read properties of undefined (reading 'getAttribute')
Stack trace:
 >  at MudPopover.callback (https://localhost:44355/_content/MudBlazor/MudBlazor.min.js:220:138)

at

const tickValue=parseInt(popoverContentNode.getAttribute('data-ticks'))

EDIT: Not fixed with full rebuild + cleared cache.

Comment thread src/MudBlazor/TScripts/mudPopover.js Outdated
Comment thread src/MudBlazor/TScripts/mudPopover.js Outdated
@versile2

Copy link
Copy Markdown
Contributor Author

When launching the test viewer I get:

TypeError: Cannot read properties of undefined (reading 'getAttribute')
Stack trace:
 >  at MudPopover.callback (https://localhost:44355/_content/MudBlazor/MudBlazor.min.js:220:138)

at

const tickValue=parseInt(popoverContentNode.getAttribute('data-ticks'))

EDIT: Not fixed with full rebuild + cleared cache.

Added some logic to prevent this in future.

@sonarqubecloud

Copy link
Copy Markdown

@danielchalmers danielchalmers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MudSelect seems to flicker on mouse click

Video.mp4

@versile2

Copy link
Copy Markdown
Contributor Author

MudSelect seems to flicker on mouse click
Video.mp4

yeah that's the mudselect bug, I thought that fix was already merged?

mudselect.mp4

@danielchalmers

Copy link
Copy Markdown
Member

Will wait on #10740 merge to re-review

@danielchalmers danielchalmers merged commit 9c84ee9 into MudBlazor:dev Jan 30, 2025
@versile2 versile2 deleted the fix/10723 branch February 3, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudSelect inside Dialog's Drawer: Select overlay not showing up Cannot close DataGrid filter when inside a MudDialog

3 participants