MudAutocomplete, MudSelect: Fix Focus and Clear#10740
MudAutocomplete, MudSelect: Fix Focus and Clear#10740danielchalmers merged 19 commits intoMudBlazor:devfrom
Conversation
…Blazor#10643)" This reverts commit 10a60e0.
danielchalmers
left a comment
There was a problem hiding this comment.
small api tweak to match mudmask
|
Are there any other controls that have a clear button that are afflicted by this? |
from ValueTask to Task Co-authored-by: Daniel Chalmers <daniel.chalmers@outlook.com>
none that I'm aware of or that has been reported |
|
Sorry, is AutocompleteRetainFocusTest the right example or is it for the other PR? I'm seeing a message box when I try to clear the field. Video3.mp4 |
|
@ScarletKuro Could you take a look at the property logic when you get a chance? |
No just the Docs autocomplete first example is what I used here. I did go ahead and add the logic in autocompleterefocustest to prevent popup when the value is empty |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10740 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 427 427
Lines 13425 13428 +3
Branches 2589 2591 +2
=======================================
+ Hits 12329 12332 +3
Misses 523 523
Partials 573 573 ☔ View full report in Codecov by Sentry. |
|
ScarletKuro
left a comment
There was a problem hiding this comment.
LGTM, I haven't tested personally so feel free to merge if ya confident



Description
Resolves #10733 by allowing the Clear button to actually clear the values
Resolves #10705 by reordering the focus logic
Resolves #10718 by removing additional click handler
Resolves #10739
How Has This Been Tested?
Unit tests passing after changing Click(s) to MouseDown(s), Visual tests done with video in comments.
Type of Changes
Checklist
dev).