Skip to content

MudTabPanel: Add Visible property#10797

Merged
danielchalmers merged 6 commits into
MudBlazor:devfrom
Apflkuacha:TabPanelAddVisibleProperty
Feb 7, 2025
Merged

MudTabPanel: Add Visible property#10797
danielchalmers merged 6 commits into
MudBlazor:devfrom
Apflkuacha:TabPanelAddVisibleProperty

Conversation

@Apflkuacha
Copy link
Copy Markdown
Contributor

@Apflkuacha Apflkuacha commented Feb 3, 2025

Description

I added a visible property for the MudTabPanel and also extended a example in the doku. I thought I extend an existing example as one example per property is not very intuitive. That fixes #10722

How Has This Been Tested?

visually
if a UnitTest is necessary I would need the information which UnitTest I could extend or copy and adapt.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions Bot added docs Changes to project docs site that do not affect core library logic enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Feb 3, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.86%. Comparing base (13a89f8) to head (4c0f938).
Report is 16 commits behind head on dev.

Files with missing lines Patch % Lines
src/MudBlazor/Components/Tabs/MudTabPanel.razor.cs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10797      +/-   ##
==========================================
+ Coverage   91.83%   91.86%   +0.02%     
==========================================
  Files         427      427              
  Lines       13430    13454      +24     
  Branches     2592     2596       +4     
==========================================
+ Hits        12334    12359      +25     
  Misses        523      523              
+ Partials      573      572       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/MudBlazor/Components/Tabs/MudTabPanel.razor.cs
Comment thread src/MudBlazor/Components/Tabs/MudTabPanel.razor.cs Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 7, 2025

Copy link
Copy Markdown
Member

@danielchalmers danielchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Apflkuacha, tweaked a few things and merging it now!

@danielchalmers danielchalmers changed the title MudTabPanel: add visible property MudTabPanel: Add Visible property Feb 7, 2025
@danielchalmers danielchalmers merged commit bc72641 into MudBlazor:dev Feb 7, 2025
@Apflkuacha
Copy link
Copy Markdown
Contributor Author

@ScarletKuro This pull request is included in the new 8.3 release, but not mentioned in the Release notes, should probably be in the New Features section. Just to increase my knowledge: are the release notes created by someone using compare/v8.2.0...v8.3.0 and not created by some automation?

@ScarletKuro
Copy link
Copy Markdown
Member

It's auto, but when it has the label 'docs,' it's excluded from release. When you're making a feature request, you don't select 'documentation' under the type of change, since it usually goes without saying for new features. We only select it when it's a pure documentation change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudTabPanel: Add a Visible property

3 participants