MudDataGrid: Use key row item instead of row index.#10845
Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom Feb 15, 2025
Merged
MudDataGrid: Use key row item instead of row index.#10845ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro merged 2 commits intoMudBlazor:devfrom
Conversation
ScarletKuro
approved these changes
Feb 10, 2025
Member
|
I think you could integrate the test from you issue to the bUnit, so it doesn't get broken in future like it was before, this is very easy to break without getting noticed |
|
Contributor
Author
|
@ScarletKuro Added a bUnit test case as requested. I verified the test fails with the old code and passes with the new. Unrelated ValidAttributeTests are failing it seems here, but I saw that's an issue with a sdk change you mentioned elsewhere. |
4 tasks
This was referenced Aug 18, 2025
This was referenced Oct 5, 2025
This was referenced Dec 29, 2025
This was referenced Jan 9, 2026
This was referenced Feb 23, 2026
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This is reverting a change made for .net 8 version of MudBlazor that causes issues (not sure exactly when it was done).
MudDataGrid was changed such that the
<tr>elements were given a@keyequal to the row index of the<tr>instead of the user supplied item. This does not match the purpose of@keywhich is to help maintain the relationship between Blazor components in a sequence and their corresponding models. This can cause odd and subtle issues. See bug report for details.fixes #10802
How Has This Been Tested?
Visually confirmed using code referenced in Reproduction link of #10802.
Also added bUnit test that verifies child components of rows are recreated - indicating the row's key is using the row item. Verified the test fails with the old MudDataGrid code (which keys off row index) and passes with new code (keys off row item).
Type of Changes
Checklist
dev).