Skip to content

MudChip: Fix memory allocation#10913

Merged
ScarletKuro merged 3 commits intoMudBlazor:devfrom
ScarletKuro:chip_alloc
Feb 20, 2025
Merged

MudChip: Fix memory allocation#10913
ScarletKuro merged 3 commits intoMudBlazor:devfrom
ScarletKuro:chip_alloc

Conversation

@ScarletKuro
Copy link
Copy Markdown
Member

@ScarletKuro ScarletKuro commented Feb 20, 2025

Description

Fixes: #10911

Additionally, the ObserverManager has been improved. Technically, these new methods should prevent dictionary copies, unless the ConcurrentDictionary copies the dictionary on its own when Value is called to avoid collection modified exceptions. However, I’m unsure how the ConcurrentDictionary is implemented in this case.

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions Bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Feb 20, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (13a7f64) to head (99db77b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10913   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         427      427           
  Lines       13570    13576    +6     
  Branches     2599     2601    +2     
=======================================
+ Hits        12473    12479    +6     
  Misses        524      524           
  Partials      573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link
Copy Markdown

@ScarletKuro ScarletKuro merged commit 831b631 into MudBlazor:dev Feb 20, 2025
@ScarletKuro ScarletKuro deleted the chip_alloc branch February 20, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudChip KeyInterceptor runaway allocations/memory leak

1 participant