Skip to content

MudPopover: Remove shadow if the popover is empty#11040

Merged
ScarletKuro merged 2 commits into
MudBlazor:devfrom
danielchalmers:popover-empty-shadow
Mar 17, 2025
Merged

MudPopover: Remove shadow if the popover is empty#11040
ScarletKuro merged 2 commits into
MudBlazor:devfrom
danielchalmers:popover-empty-shadow

Conversation

@danielchalmers
Copy link
Copy Markdown
Member

@danielchalmers danielchalmers commented Mar 17, 2025

Description

Simply removes the shadow if the popover has no content. Resolves #10628

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Before:

Video3.mp4

After:

Video2.mp4

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions Bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Mar 17, 2025
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.05%. Comparing base (e5f6908) to head (4147590).
Report is 8 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #11040      +/-   ##
==========================================
+ Coverage   91.01%   91.05%   +0.03%     
==========================================
  Files         429      429              
  Lines       13946    13956      +10     
  Branches     2696     2698       +2     
==========================================
+ Hits        12693    12707      +14     
+ Misses        648      646       -2     
+ Partials      605      603       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ScarletKuro ScarletKuro merged commit 7a1d720 into MudBlazor:dev Mar 17, 2025
@Garderoben
Copy link
Copy Markdown
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudAutocomplete - shows popover box shadow on focus when there is no matching items

3 participants