Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1739 - MudMessageBox action buttons order reversed #1741

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

JonBunator
Copy link
Member

Fixes #1739
Changes the order of MudMessageBox action buttons from: Yes -> No -> Cancel to Cancel -> No -> Yes

@porkopek
Copy link
Contributor

porkopek commented Jun 1, 2021

you can change those with just CSS, can't you?

@JonBunator
Copy link
Member Author

you can change those with just CSS, can't you?

I didn't want to add extra unnecessary css when you can just change the order. Don't you agree?
But I am seeing that tests are failing. (For some reason they worked locally)

@porkopek
Copy link
Contributor

porkopek commented Jun 1, 2021

you can change those with just CSS, can't you?

I didn't want to add extra unnecessary css when you can just change the order. Don't you agree?
But I am seeing that tests are failing. (For some reason they worked locally)

I think if you change the order, you're going to have to change the tests. They seem to rely on the order of the buttons?
I was suggesting CSS just for the user demanding this, so he could fix it in his app, but I don't really know if this has to be fixed already in the library, because I don't know the consequences

But, hey, maybe you're right. I didn't see the Material Specs

@JonBunator
Copy link
Member Author

you can change those with just CSS, can't you?

I didn't want to add extra unnecessary css when you can just change the order. Don't you agree?
But I am seeing that tests are failing. (For some reason they worked locally)

I think if you change the order, you're going to have to change the tests. They seem to rely on the order of the buttons?
I was suggesting CSS just for the user demanding this, so he could fix it in his app, but I don't really know if this has to be fixed already in the library, because I don't know the consequences

But, hey, maybe you're right. I didn't see the Material Specs

Ah now I get what you meant. I agree with him that the order should be like the material specs. But I can also close this if you want :)

@porkopek
Copy link
Contributor

porkopek commented Jun 1, 2021

Don't close it, just change the tests to pass.
I left others the responsibility of choose the best decision.
I think it doesn't have priority, but once that you got it done... let's add it

@JonBunator JonBunator force-pushed the fix/message-box-button-order branch from 7422d5a to 4995a41 Compare June 1, 2021 16:21
@henon henon merged commit 22b0b8a into MudBlazor:dev Jun 3, 2021
@henon henon added this to the 5.0.11 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudMessageBox button placement
3 participants