Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudAvatar: added variant outlined #1929

Merged
merged 2 commits into from
Jun 20, 2021

Conversation

boukenka
Copy link
Contributor

@boukenka boukenka commented Jun 19, 2021

This PR is a proposition for Avatar with border feature request. Below is the result.

pop

@Garderoben Garderoben self-requested a review June 20, 2021 15:15
@Garderoben
Copy link
Member

How does it look with just 1px border? feels a bit to thick with 2px.

@boukenka
Copy link
Contributor Author

Voilà! What do you think? If you prefer with 1px border, I will update the PR.

Sans titre

@Garderoben
Copy link
Member

Voilà! What do you think? If you prefer with 1px border, I will update the PR.

Sans titre

Allot better, update the PR and i aprove it :)

@boukenka
Copy link
Contributor Author

This is done!

@Garderoben Garderoben merged commit ee09927 into MudBlazor:dev Jun 20, 2021
@boukenka boukenka deleted the borderedcoloredavatar branch June 20, 2021 17:21
@boukenka
Copy link
Contributor Author

@Garderoben Thank you!

@henon henon changed the title Border addition for MudAvatar MudAvatar: added variant outlined Jun 20, 2021
@henon henon added this to the 5.0.14 milestone Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants