Carousel: Improve accessibility #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HClausing
reviewed
Jun 24, 2021
JonBunator
reviewed
Jun 24, 2021
| @@ -0,0 +1,4 @@ | |||
| @namespace MudBlazor.UnitTests.TestComponents | |||
|
|
|||
| <MudAlert Severity="Severity.Normal">The reactor type is RBMK-1000</MudAlert> | |||
There was a problem hiding this comment.
It wasn't necessary. I removed it
|
Its great we are thinking accessibility but I would prefer to see one PR per component. Even if they are small changes |
KamilBugnoKrk
changed the title
|
@KamilBugnoKrk I read you blog article about accessibility and was inspired. Such an important part of web design for the people with sight difficulties which is often forgotten. Thanks for the PRs |
|
The carousel component support background images? |
Globally not, You should setup background for every MudCarouselItem (page). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carousel: used section instead of div, added labels to prev/next buttons, and change the order of tab index