Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudBadge: Added OnClick event #2010

Merged
merged 1 commit into from
Jun 28, 2021
Merged

MudBadge: Added OnClick event #2010

merged 1 commit into from
Jun 28, 2021

Conversation

Mr-Technician
Copy link
Member

I talked with @porkopek a couple days ago about adding an OnClick event to the MudBadge. I'm adding a draft PR as I expect there will be additional changes to make, maybe as a different CSS class for badges with a click event etc.

Not sure what happened to the commit history though...

@mikes-gh
Copy link
Contributor

You should use rebase not merge for PRs
That why the history is messed up. This PR is still mergeable though

@henon
Copy link
Collaborator

henon commented Jun 26, 2021

@Mr-Technician can you fix the PR? it is hard to review with all the other commits. Reset your branch --hard to dev and cherry pick that one commit. then force push the branch.

@Mr-Technician
Copy link
Member Author

My bad, all fixed now. I pushed this quick before bed, should have been more careful. 😛 @henon

@henon henon marked this pull request as ready for review June 28, 2021 09:26
@henon henon merged commit 04d2f27 into MudBlazor:dev Jun 28, 2021
@henon
Copy link
Collaborator

henon commented Jun 28, 2021

Looks good, thanks.

@henon henon added this to the 5.0.15 milestone Jun 28, 2021
@henon henon changed the title Added OnClick event to MudBadge MudBadge: Added OnClick event Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants