Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudSelect; Invoking SelectedValuesChanged before text is rendered #2287

Merged
merged 8 commits into from
Jul 20, 2021

Conversation

MattChique
Copy link
Contributor

Fixed #2261

@henon
Copy link
Collaborator

henon commented Jul 19, 2021

Great. A simple test where you use the event to remove something from the selected values and check that the text is then correctly rendered would be awesome so nobody can move it back (for whatever reason). you know how it is, code changes, people refactor stuff.

@Flaflo
Copy link
Contributor

Flaflo commented Jul 20, 2021

@henon Please review the changes!

@henon henon merged commit b098d9b into MudBlazor:dev Jul 20, 2021
@henon
Copy link
Collaborator

henon commented Jul 20, 2021

Thanks MattChique!

@henon henon added this to the 5.1.0 milestone Jul 20, 2021
henon added a commit to henon/MudBlazor that referenced this pull request Aug 8, 2021
…ered (MudBlazor#2287)"

This reverts commit b098d9b.

# Conflicts:
#	src/MudBlazor.UnitTests/Components/SelectTests.cs
henon added a commit to henon/MudBlazor that referenced this pull request Aug 8, 2021
…ered (MudBlazor#2287)"

This reverts commit b098d9b.

# Conflicts:
#	src/MudBlazor.UnitTests/Components/SelectTests.cs
henon added a commit to henon/MudBlazor that referenced this pull request Aug 8, 2021
…ered (MudBlazor#2287)"

This reverts commit b098d9b.

# Conflicts:
#	src/MudBlazor.UnitTests/Components/SelectTests.cs
henon added a commit to henon/MudBlazor that referenced this pull request Aug 8, 2021
henon added a commit that referenced this pull request Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudSelect: TextFuncs are called before SelectedValuesChanged is invoked
3 participants