Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu: Prevent item click when drop-down is closed #2654

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

mckaragoz
Copy link
Member

@mckaragoz mckaragoz commented Sep 6, 2021

This is the same approach in #2647, this time implement on MudMenu.

I create a temporary example described on #2509 and it seemed to solve this. @henon

But we should notice that, this approach doesn't solve all issues. Ex. having two menus when clicking a menu on AppBar still remains (Maybe these related to Portal).

fixes #2509

@henon henon merged commit dc9cbab into MudBlazor:dev Sep 7, 2021
@henon henon added this to the 5.1.4 milestone Sep 7, 2021
@henon
Copy link
Collaborator

henon commented Sep 7, 2021

OK, Thanks.

@mckaragoz mckaragoz deleted the MudMenuClick branch September 7, 2021 12:11
Garderoben added a commit that referenced this pull request Oct 2, 2021
* first try of new portal (#2684)

* MudPopover: first draft  of new placement method

* popover: adding max-width to  popover

* MudPopover: add RelativeWidth as an optional parameter

* MudPopover: enable window resize to trigger reposition

* Popover: Adopted for new enum and new popover

* Tooltip: Adopted for new enum and new popover

* Docs: Updated Tooltip page

* AutoComplete: Fixed for new popover

* TEMPORARY CHANGES

* MudPopover: placement for popovers

* Popover: Introduction of PopoverProvider

* Popover fixed

* Popover: Implementing is fixed property

* AppBar: Removed Cascading Value

* Removed Fixed from AutoComplete

* Tooltip: Added css for Arrow's and positioning

* Tooltip: Added functionality for arrows and positioning

* Menu: removed unused CSS

* CSS Classes: Added color themed border classes

* Docs: Removed usage of AutoComplete Fixed

* Menu: Reverted #2654 not needed with working popover

* Select: Reverted #2647 not needed with working popover

* Popover: Added overflow-y-auto when MaxHeight is used

* Popover: Added CSS class to act as "Cascading Value"

* Docs: Added Arrow examples for tooltip

* Docs: Added Color examples for tooltip

* Docs: Updated Tooltip page

* Updated Temporary Docs.js

* Removed Fixed from AutoComplete

* MudPopover: render only if open

* Docs: Finished Tooltip page and examples

* Docs: Started work on Popover page and examples

* Badge: Started converting it to Placement

* Popover: Added example for complex content

* Popover: typo fixed in docs

* MudPicker: Change inline mode to use popover

* Popover: placement system try number 2

* Added End & Start back to Placement

* PopoverPlacement -> Origin temporary name

* Badge: Converted to Origin

* Tooltip: fixed so it works with new popover

* Select: fixed so it works with new popover

* Menu: fixed so it works with new popover

* AutoComplete: fixed so it works with new popover

* Picker: Fixed so they can be closed and works with new popover

* Tooltip: Removed unused Direction

* Popover: Changed some comments and parameters

* Docs: Updated Popover page

* Picker: Set default values directly for Popover

* Select: Added functionality for new Popover and old parameters

* Autocomplete: moved MaxHeight back to popover

test it in several cases and works?

* Docs: Updated Select page

* DocsJS: Fixed a popover bug

* Autocomplete: Obsolete old popover, added backward compatibility

* Menu: Converted to new popover, added backward compability

* Menu: Updated Menu to work with change able popover origins

* Docs: Updated Select page

* Docs: Updated Menu page to for new Popover

* Docs: Popover removed unused ref

* Docs: Finished Menu pages with new Popover

* Popover: Added Test page to track issues

* Popover / Theme: Started working on Z-Index / Overlapping fix

* Added one more issue to test

* Popover: Added CSS for popovers in appbar, dialog, drawers

* Tooltip: Fix for #1171

* Overlay: Added null checks to not display unnecessary DOM

* Popover Tests: Two more tests are now possitive

* Added test to check textfields with helpertext + popover

* MudPopver: popover inception first try

* Updated the TestRazor page

* MudMenu: Added List Class parameter

* MudPopover: Added missing comment

* MudMenu: Fixed PositionAtCurser with new popover

* Docs: removed the razor test page we used for dev

* Docs: Updated Select page

* Docs: Updated Popover page

* Docs: Updated Menu page

* MudPopover: refractor popoverjs and add popoveroptions

* MudPopover: changed obsolete messages to new parameters

* Popover: working on fixing the tests

* Popover: fixing more unit tests

* Popover: last test for muselect fixed

* MudSelect: Establishing a way to have components but not their visuals

* Popover: add test specific to this component

* trying to fix the unit test erros

* trying to find the reason for failing tests

* and another try...

* and fixing other tests too

* PopoverHandler ensure non null values

* providing non null RenderFragement for MockPopoverService

Co-authored-by: Benjamin Kappel <51370361+just-the-benno@users.noreply.github.com>
Co-authored-by: Benjamin Kappel <b.kappel90@outlook.de>
henon pushed a commit that referenced this pull request Oct 22, 2021
* first try of new portal (#2684)

* MudPopover: first draft  of new placement method

* popover: adding max-width to  popover

* MudPopover: add RelativeWidth as an optional parameter

* MudPopover: enable window resize to trigger reposition

* Popover: Adopted for new enum and new popover

* Tooltip: Adopted for new enum and new popover

* Docs: Updated Tooltip page

* AutoComplete: Fixed for new popover

* TEMPORARY CHANGES

* MudPopover: placement for popovers

* Popover: Introduction of PopoverProvider

* Popover fixed

* Popover: Implementing is fixed property

* AppBar: Removed Cascading Value

* Removed Fixed from AutoComplete

* Tooltip: Added css for Arrow's and positioning

* Tooltip: Added functionality for arrows and positioning

* Menu: removed unused CSS

* CSS Classes: Added color themed border classes

* Docs: Removed usage of AutoComplete Fixed

* Menu: Reverted #2654 not needed with working popover

* Select: Reverted #2647 not needed with working popover

* Popover: Added overflow-y-auto when MaxHeight is used

* Popover: Added CSS class to act as "Cascading Value"

* Docs: Added Arrow examples for tooltip

* Docs: Added Color examples for tooltip

* Docs: Updated Tooltip page

* Updated Temporary Docs.js

* Removed Fixed from AutoComplete

* MudPopover: render only if open

* Docs: Finished Tooltip page and examples

* Docs: Started work on Popover page and examples

* Badge: Started converting it to Placement

* Popover: Added example for complex content

* Popover: typo fixed in docs

* MudPicker: Change inline mode to use popover

* Popover: placement system try number 2

* Added End & Start back to Placement

* PopoverPlacement -> Origin temporary name

* Badge: Converted to Origin

* Tooltip: fixed so it works with new popover

* Select: fixed so it works with new popover

* Menu: fixed so it works with new popover

* AutoComplete: fixed so it works with new popover

* Picker: Fixed so they can be closed and works with new popover

* Tooltip: Removed unused Direction

* Popover: Changed some comments and parameters

* Docs: Updated Popover page

* Picker: Set default values directly for Popover

* Select: Added functionality for new Popover and old parameters

* Autocomplete: moved MaxHeight back to popover

test it in several cases and works?

* Docs: Updated Select page

* DocsJS: Fixed a popover bug

* Autocomplete: Obsolete old popover, added backward compatibility

* Menu: Converted to new popover, added backward compability

* Menu: Updated Menu to work with change able popover origins

* Docs: Updated Select page

* Docs: Updated Menu page to for new Popover

* Docs: Popover removed unused ref

* Docs: Finished Menu pages with new Popover

* Popover: Added Test page to track issues

* Popover / Theme: Started working on Z-Index / Overlapping fix

* Added one more issue to test

* Popover: Added CSS for popovers in appbar, dialog, drawers

* Tooltip: Fix for #1171

* Overlay: Added null checks to not display unnecessary DOM

* Popover Tests: Two more tests are now possitive

* Added test to check textfields with helpertext + popover

* MudPopver: popover inception first try

* Updated the TestRazor page

* MudMenu: Added List Class parameter

* MudPopover: Added missing comment

* MudMenu: Fixed PositionAtCurser with new popover

* Docs: removed the razor test page we used for dev

* Docs: Updated Select page

* Docs: Updated Popover page

* Docs: Updated Menu page

* MudPopover: refractor popoverjs and add popoveroptions

* MudPopover: changed obsolete messages to new parameters

* Popover: working on fixing the tests

* Popover: fixing more unit tests

* Popover: last test for muselect fixed

* MudSelect: Establishing a way to have components but not their visuals

* Popover: add test specific to this component

* trying to fix the unit test erros

* trying to find the reason for failing tests

* and another try...

* and fixing other tests too

* PopoverHandler ensure non null values

* providing non null RenderFragement for MockPopoverService

* MudPopover: the content resize listener is now reinitlize if the main content node has been removed/added

* MudTooltipManager: first draft

* Reverting changes for ToolTipManager

* MudPopover: Overflow with Flip

* MudPopover: Overflowbehavior cleanup and testing

* Removed DeterminePosition from Picker and replaced it with the new Popover overflow behavior

* MudPopover: changed default overflow behaviour and default flip offset

* Fixing tooltip bug mentioned in #2976

* Show that #2976 can't be reproduced with unit tests

* Theme: Changed default Z-Indexes

* Pickers: Fixed flipping behavior for pickers

* Fixed broken tests

* AutoComplete: added back parameters that got lost in merge

* Picker: Fixed broken code after merge

* Select: Fixed broken code after merge

* Docs: Updated Popover Overflow example

* AutoComplete: Fixed scroll inside list on key navigation.

* Docs: Menu cutted down on placment examples.

* Badge: Fixed placement of badge with new origin system

* Docs: Fixed Popover example after badge fix

* Docs: Cleaned up some select popover examples

* Popover: Fix opacity bug, remove portal css (#3037)

* Popover: Fixed scroll for mudlists with max height

* AutoComplete: Changed to the real scroll fix

* Updated to 5.2.0-rc1

* MudPopoverJS: turned off loggin

* Updated to 5.2.0-rc1

* Updated to 5.2.0-rc2

* mudpopover: fixing task cancel exception

* MudPopover: popover fixed so that the API page can be displayed

* IconButton: Fixed separate focus/hover for keyboard and mouse.

* Switch: Fixed separate focus/hover for keyboard and mouse.

* Radio: Fixed separate focus/hover for keyboard and mouse.

* Link: Fixed separate focus/hover for keyboard and mouse.

* CSS Reset: removed missed outline on a elements

* CheckBox: Fixed separate focus/hover for keyboard and mouse.

* ButtonFAB: Added focus style on keyboard navigation

* Button: Added focus style on keyboard navigation

* ButtonGroup: Added focus style on keyboard navigation

* Chip: Added focus style on keyboard navigation

* List: Added focus style on keyboard navigation

* Slider: Added focus style on keyboard navigation and mouse hover

* DatePicker: Fixed selected month color

* DatePicker: Changed selected day button to outlined.

* Popover: delay/duration options.

* Tooltip: Fixed weird bug where it spawned in wrong place.

* Tooltip: Removed dev debuggning

* Tooltip/Popover fixed duration

* modify flip behaviour for popover

* Tooltip: Fixed HTML Tooltip to display as before

* Popover/Tooltip: Fixed failing tests

* Tooltip: Fixed tests

* adding test for popover flip

* fliponce is working properly with menu

* Docs: Updated Popover examples

* fixes for flip always

* rename mudpopover OverflowBehavior enum values

* Auto stash before merge of "feature/portal" and "origin/feature/portal"

* Docs: Popover overflow behavior updated

* Docs: Popover Overflow example corrected enum values

* Tooltip: Added optional show on touch (#3073)

* Popover: Fixed z-index when inside temp or responsive drawer (#3046)

* move js from doc to mudpopover

* Popover: Fixed delay and duration

* Docs: Tooltip delayed example updated

* Popover: Updated tests with new parameter names

* Updated to 5.2.0-rc3

* removed static from semaphores

* adding test for tooltips

* Feature/docs api link (#3081)

* Select: Fix not losing focus on first click outside of select (#3078)

* Hot fix for docs links

Co-authored-by: Mehmet Can Karagöz <78308169+mckaragoz@users.noreply.github.com>

* Update to 5.2.0-rc4

* Docs: Fix tooltip example (#3079)

* fixing popover placement on first time opening when relative widht is set

* Pickers: Fixed lost styling for action buttons (#3102)

* reworked IsEnabled on MudPopoverProvider

* Tooltip: Removed toutch event (#3073)

* Tooltip: prevent the wrapper from growing (#3080)

* Popover: Added anchor flipping on center

* Tooltip: removed toutch from tests

* Tooltip: Anchor flip

* Tooltip: removed toutch test

Co-authored-by: Benjamin Kappel <51370361+just-the-benno@users.noreply.github.com>
Co-authored-by: Benjamin Kappel <b.kappel90@outlook.de>
Co-authored-by: Jonas B <62108893+JonBunator@users.noreply.github.com>
Co-authored-by: Jason Gutierrez <jasong84@gmail.com>
Co-authored-by: Mehmet Can Karagöz <78308169+mckaragoz@users.noreply.github.com>
Co-authored-by: Jonas B <jonasmitb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudMenu Anchor is still clickable when it shouldn't
2 participants