Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Add default collapse option to basic table grouping #2683

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Table: Add default collapse option to basic table grouping #2683

merged 1 commit into from
Sep 13, 2021

Conversation

SGarvin
Copy link
Contributor

@SGarvin SGarvin commented Sep 9, 2021 •
edited by henon
Loading

Tables using simple grouping can now have all groups collapsed by default. This helps users view only the information they want in large tables.
image

fixes #2683

@mckaragoz
Copy link
Member

mckaragoz commented Sep 9, 2021 •
edited
Loading

Very good. Should we change the GroupDefaultAsExpanded name to more clear one?

@SGarvin
Copy link
Contributor Author

SGarvin commented Sep 9, 2021

I agree that it can be improved, but I couldn't think of a better one. Any suggestions?

@mckaragoz
Copy link
Member

@henon is good to finding usable names 🙂 maybe it can "ExpandedGroup" or "IsGroupExpanded".

@henon
Copy link
Collaborator

henon commented Sep 10, 2021

we can not make it GroupExpanded because it is just an initial value. We have IsExpanded which is the state of the group. The most logical name therefor would be IsExpandedInitially. This matches naming in ExpansionPanel where we have the same IIRC.

@henon
Copy link
Collaborator

henon commented Sep 10, 2021

@HClausing as the original author of grouping, would you look at it?

@Yomodo
Copy link
Contributor

Yomodo commented Sep 10, 2021 •
edited
Loading

@henon: As an addition to IsExpanded, IsInitiallyExpanded sounds more natural in a .NET way.

@henon
Copy link
Collaborator

henon commented Sep 10, 2021

@henon: As an addition to IsExpanded, IsInitiallyExpanded sounds more natural in a .NET way.

ok, I agree

@HClausing
Copy link
Member

HClausing commented Sep 10, 2021 •
edited
Loading

@HClausing as the original author of grouping, would you look at it?

Sure @henon !

HClausing
HClausing suggested changes Sep 10, 2021
View reviewed changes
Copy link
Member

@HClausing HClausing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thank you so much!

src/MudBlazor/Components/Table/TableGroupDefinition.cs Outdated Show resolved Hide resolved
@HClausing HClausing mentioned this pull request Sep 10, 2021
Closed
@SGarvin
Copy link
Contributor Author

SGarvin commented Sep 13, 2021

Much better name. I applied the refactor. Thanks everyone!

@henon henon merged commit 439a092 into MudBlazor:dev Sep 13, 2021
@henon
Copy link
Collaborator

henon commented Sep 13, 2021

Thanks Garvin!

@henon henon added this to the 5.1.4 milestone Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HClausing HClausing HClausing requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@SGarvin @mckaragoz @henon @Yomodo @HClausing