DateRangePicker: Fix not updating validation-status #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* set end-date (as both has to be set) * added test to viewer-project
|
what do you mean with it is great that you added a test component. to make sure this fix will never be unfixed accidentally by future PRs please also add a bUnit test which uses your new test component to verify the behavior. Should be very easy when you look at the other tests. |
|
@henon bUnit-test added. Hope this one can be released soon as this currently is some kind of show-stopper for my current development (working around with two dedicated DatePickers using the selected date as min/max for the other picker). |
|
Perfect job! Thanks. No worries, we release quite often. If you want you can get in touch with @Garderoben on Discord. He'll know about the timing of the next release. |
henon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described #1428 I've set the internal
_valueto the range's end-date so it fullfills theRequiredcondition.Maybe @henon can take care of this as he initially added the
Required-feature forDateRangePickers in the first place.