Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar: Added capability to set alt property when Image is used #2894

Merged

Conversation

digitalanalogue9
Copy link
Contributor

@digitalanalogue9 digitalanalogue9 commented Sep 29, 2021

Description

Resolves #2893
Added Alt property to MudAvatar so that when an Image is used, it is possible to set the alt property of the img element.

Motivation and Context

Lighthouse accessibility test

How Has This Been Tested?

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in library)

@JonBunator JonBunator added the enhancement New feature or request label Sep 30, 2021
Copy link
Member

@JonBunator JonBunator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you also add an example to the docs, please?

@digitalanalogue9
Copy link
Contributor Author

@JonBunator - docs updated :)

Copy link
Member

@JonBunator JonBunator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you :)

@JonBunator JonBunator added this to the 5.2.0 milestone Oct 1, 2021
@JonBunator JonBunator merged commit f0d3c4a into MudBlazor:dev Oct 1, 2021
@mikes-gh mikes-gh changed the title Added capability to set alt property when Image is used in MudAvatar Avatar: Added capability to set alt property when Image is used Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar Alt property
2 participants