Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Fix for inner level grouping with paginated data #2910

Merged
merged 1 commit into from Oct 9, 2021

Conversation

HClausing
Copy link
Member

@HClausing HClausing commented Oct 1, 2021

Description

This is a fix for #2809 , when the inner level groups was statically displaying entries of the first page only, instead using the new ones from the current page.

This behavior can be observed here: https://try.mudblazor.com/snippet/GawPOXcwxFDtWOgi

How Has This Been Tested?

Created a new test, counting the number of Group Rows and Data Rows, then, simulated navigation to the next page, and counting the rows again.

Visual tests were evaluated also.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@JonBunator JonBunator linked an issue Oct 1, 2021 that may be closed by this pull request
2 tasks
@JonBunator JonBunator added the bug Something does not work as intended/expected label Oct 1, 2021
@henon
Copy link
Collaborator

henon commented Oct 9, 2021

Very nice. Thanks!

@henon henon merged commit da2a2ff into MudBlazor:dev Oct 9, 2021
@henon henon added this to the 5.2.0 milestone Oct 9, 2021
@HClausing HClausing deleted the #2809 branch October 13, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table using ServerData and Group with InnerGroup display duplicate data
3 participants