Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: Keyboard Navigation #2929

Merged
merged 59 commits into from
Oct 11, 2021
Merged

Conversation

mckaragoz
Copy link
Member

@mckaragoz mckaragoz commented Oct 2, 2021

Description

Keyboard nav in select. open with Enter or Space, select item with arrows, in multiselect check/uncheck with Enter

fix #476, fix #1047, fix #2077, fix #2428. also fixes #2905.

Fixes:
Clicking a select item not causes the lost focus, so user can use keys easily after click
All selects can accept tabfocus (Selects which have RenderFragment didn't focus on tab key before)

How Has This Been Tested?

Types of changes

  • New feature (non-breaking change which adds functionality)
20211005_234601.mp4

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@JonBunator JonBunator added the enhancement New feature or request label Oct 3, 2021
@henon
Copy link
Collaborator

henon commented Oct 11, 2021

@mckaragoz Damn, my quick merge introduced a bug. You need to undo it. And find out which commit in dev conflicts this and do a merge that applies both changes without breaking either. This is very delicate.

…gation

# Conflicts:
#	src/MudBlazor.UnitTests/Components/SelectTests.cs
#	src/MudBlazor/Components/Select/MudSelect.razor.cs
@henon
Copy link
Collaborator

henon commented Oct 11, 2021

I fixed the merge

@henon henon merged commit 59deb92 into MudBlazor:dev Oct 11, 2021
@henon henon added this to the 5.2.0 milestone Oct 11, 2021
@henon
Copy link
Collaborator

henon commented Oct 11, 2021

Note: this PR does not yet provide scrolling of long lists with keyboard navigation. It will be added in a separate PR

@mckaragoz
Copy link
Member Author

I will add this on a seperate issue

@mckaragoz mckaragoz deleted the SelectKeyboardNavigation branch October 11, 2021 15:39
@henon henon added the hacktoberfest accepted Issues and PRs which were accepted as Hacktoberfest submissions label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest accepted Issues and PRs which were accepted as Hacktoberfest submissions
Projects
None yet
3 participants