Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker: Add Basic Keyboard Navigation #2933

Merged
merged 12 commits into from
Oct 9, 2021

Conversation

mckaragoz
Copy link
Member

@mckaragoz mckaragoz commented Oct 3, 2021

Description

We add a fundamental keyboard navigation to all pickers. It required for the further detailed PR's for each component.

It includes:

Enter or Alt + ArrowDown key to open, (except the static pickers)
Escape or Alt + ArrowUp key to close, (except the static pickers)
Space key to toggle open/close. (except the editable pickers)

Also fix the picker content problem, that not closing on pressing tab and lost focus.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
20211003_205133.mp4

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@mckaragoz mckaragoz added bug Something does not work as intended/expected enhancement New feature or request labels Oct 3, 2021
@mckaragoz
Copy link
Member Author

@henon should we add tests for now? Its the very basic open close keys. I thought we can add test after this PR when working on each picker with testing also their special keys. Actually we didn't officially announced the keys with pickers, its like a base code.

@henon
Copy link
Collaborator

henon commented Oct 6, 2021

yes, but we need some tests because we don't want the coverage to go below 86%

@mckaragoz
Copy link
Member Author

mckaragoz commented Oct 9, 2021

@henon finally i was able to add the test. And also added extra tests that is not directly about Keyboard Navigaiton.

@henon henon removed the needs tests label Oct 9, 2021
@henon
Copy link
Collaborator

henon commented Oct 9, 2021

Perfect, coverage increased. Many thanks.

@henon henon added this to the 5.2.0 milestone Oct 9, 2021
@henon henon merged commit f012aa6 into MudBlazor:dev Oct 9, 2021
@henon henon changed the title Picker: Keyboard Navigation (Fundamental) Picker: Add Basic Keyboard Navigation Oct 9, 2021
@mckaragoz mckaragoz deleted the PickerKeyboardNavigation branch October 10, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants