Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form: fix form.Reset() which failed under certain conditions #3034

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Form: fix form.Reset() which failed under certain conditions #3034

merged 1 commit into from
Oct 13, 2021

Conversation

henon
Copy link
Collaborator

@henon henon commented Oct 13, 2021 •
edited
Loading

As the test shows, due to Blazor binding logic the implementation of form.Reset() did not clear a two-way bound TextField.

Description

fix #3004

How Has This Been Tested?

unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@henon henon merged commit 6061430 into MudBlazor:dev Oct 13, 2021
@henon henon added this to the 5.2.0 milestone Oct 13, 2021
@henon henon added bug Something does not work as intended/expected hacktoberfest Hacktoberfest 2021 hacktoberfest accepted Issues and PRs which were accepted as Hacktoberfest submissions labels Oct 13, 2021
@henon henon deleted the FormResetFix branch October 23, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something does not work as intended/expected hacktoberfest accepted Issues and PRs which were accepted as Hacktoberfest submissions hacktoberfest Hacktoberfest 2021
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

MudForm.Reset() not clearing textfield
1 participant
@henon