Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker: Current day button variant outlined #3069

Merged
merged 1 commit into from
Oct 17, 2021
Merged

DatePicker: Current day button variant outlined #3069

merged 1 commit into from
Oct 17, 2021

Conversation

Garderoben
Copy link
Member

Description

It was requested that we added option to set current day button variant, but instead of making changes to the api we might want to set it as outlined all the time, mui and vuetify has it like that as well.

Personally i am little split i think it might stick out to much, but it prob feels like that becuse of MudBlazors default theme colors are kinda sharp. So i would love to hear your inputs if or not to merge this.

New:

image

Old:

image

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

@Garderoben Garderoben added the enhancement New feature or request label Oct 16, 2021
@Garderoben Garderoben added this to the 5.2.0 milestone Oct 16, 2021
@henon
Copy link
Collaborator

henon commented Oct 17, 2021

I like the new design better too

@JonBunator
Copy link
Member

Yep, I also like it. This also conforms to the new material io guidelines: https://material.io/components/date-pickers
They changed date pickers a bit

@Garderoben
Copy link
Member Author

Cool then lets roll with this!

@Garderoben Garderoben merged commit 31718af into MudBlazor:dev Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants