Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer: Fixed mini mode drawer's z-index when "closed" #3206

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Drawer: Fixed mini mode drawer's z-index when "closed" #3206

merged 1 commit into from
Oct 31, 2021

Conversation

Garderoben
Copy link
Member

@Garderoben Garderoben commented Oct 30, 2021

Description

The Mini mode drawer when "closed" or in mini mode, it still received the higher z-index even when it should not. resulting in overlapping content. I changed so it only applies the z-index change if the mini drawer is "open".

Issue can be seen here:
TheDrawerIssue

How Has This Been Tested?

Manual/Visual testing.

Checklist:

✔️ The PR is submitted to the correct branch (dev).
✔️ My code follows the code style of this project.
✔️ I've added relevant tests.

@mudbot mudbot bot added bug Something does not work as intended/expected needs review labels Oct 30, 2021
@Garderoben Garderoben added this to the 5.2.0 milestone Oct 30, 2021
@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #3206 (e5f5d29) into dev (ed27a99) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3206   +/-   ##
=======================================
  Coverage   88.50%   88.50%           
=======================================
  Files         289      289           
  Lines       12868    12868           
=======================================
  Hits        11389    11389           
  Misses       1479     1479           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed27a99...e5f5d29. Read the comment docs.

@Garderoben Garderoben merged commit 6b44a0e into MudBlazor:dev Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant