When a row is clicked, only call SetEditingItem if IsEditable is true #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3245 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.01%
==========================================
Files 289 289
Lines 12863 12863
==========================================
- Hits 11389 11388 -1
- Misses 1474 1475 +1
Continue to review full report at Codecov.
|
JonBunator
added
bug
JonBunator
requested changes
Nov 3, 2021
|
Conflicts resolved |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3108 by moving the call to SetEditingItem so it is only called when IsEditable is true.
How Has This Been Tested?
Unit test added.
Checklist:
The PR is submitted to the correct branch (
dev).My code follows the code style of this project.
I've added relevant tests.