Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog: Fix Class, Style and Tag properties ignored in inline dialog #3252

Merged
merged 1 commit into from Dec 12, 2021

Conversation

peerpalo
Copy link
Contributor

@peerpalo peerpalo commented Nov 4, 2021

Description

Fixes #3128. Inline dialog should't be opened soon after setting IsVisible property because all other properties may not have been initialized yet, moved to OnAfterRender.

How Has This Been Tested?

Added unit test. Currently it's ignored like InlineDialog_Should_UpdateIsVisibleOnClose, don't know if CI supports that.

Checklist:

✔️ The PR is submitted to the correct branch (dev).
✔️ My code follows the code style of this project.
✔️ I've added relevant tests.

@mudbot mudbot bot added the needs review label Nov 4, 2021
@JonBunator JonBunator added the bug Something does not work as intended/expected label Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #3252 (fce10db) into dev (8c425e7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3252      +/-   ##
==========================================
+ Coverage   89.81%   89.82%   +0.01%     
==========================================
  Files         289      289              
  Lines        9298     9301       +3     
==========================================
+ Hits         8351     8355       +4     
+ Misses        947      946       -1     
Impacted Files Coverage Δ
src/MudBlazor/Components/Dialog/MudDialog.razor.cs 96.36% <100.00%> (+2.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c425e7...fce10db. Read the comment docs.

@mikes-gh mikes-gh changed the title MudDialog: Fix Class, Style and Tag properties ignored in inline dialog Dialog: Fix Class, Style and Tag properties ignored in inline dialog Dec 2, 2021
@henon henon merged commit 2875394 into MudBlazor:dev Dec 12, 2021
@henon
Copy link
Collaborator

henon commented Dec 12, 2021

Thanks, great PR.

@henon henon added this to the 6.0.3 milestone Dec 12, 2021
@mikes-gh mikes-gh mentioned this pull request Jan 11, 2022
2 tasks
henon added a commit to henon/MudBlazor that referenced this pull request Jan 18, 2022
henon added a commit that referenced this pull request Jan 18, 2022
* Dialog: reverting regression by #3252. Issue #3701

* Dialog test: trying to get it to work on CI
@mikes-gh
Copy link
Contributor

Also fixes #3687

peerpalo added a commit to peerpalo/MudBlazor that referenced this pull request Jan 18, 2022
henon pushed a commit that referenced this pull request Feb 17, 2022
* Dialog: Fix regression caused by #3252 (issues #3701 #3687)

* Dialog: Added InlineDialogShouldNotCloseAfterStateHasChanged test
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…udBlazor#3752)

* Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701

* Dialog test: trying to get it to work on CI
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…MudBlazor#3687) (MudBlazor#3760)

* Dialog: Fix regression caused by MudBlazor#3252 (issues MudBlazor#3701 MudBlazor#3687)

* Dialog: Added InlineDialogShouldNotCloseAfterStateHasChanged test
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…udBlazor#3752)

* Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701

* Dialog test: trying to get it to work on CI
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…MudBlazor#3687) (MudBlazor#3760)

* Dialog: Fix regression caused by MudBlazor#3252 (issues MudBlazor#3701 MudBlazor#3687)

* Dialog: Added InlineDialogShouldNotCloseAfterStateHasChanged test
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…udBlazor#3752)

* Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701

* Dialog test: trying to get it to work on CI
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…MudBlazor#3687) (MudBlazor#3760)

* Dialog: Fix regression caused by MudBlazor#3252 (issues MudBlazor#3701 MudBlazor#3687)

* Dialog: Added InlineDialogShouldNotCloseAfterStateHasChanged test
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…udBlazor#3752)

* Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701

* Dialog test: trying to get it to work on CI
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…MudBlazor#3687) (MudBlazor#3760)

* Dialog: Fix regression caused by MudBlazor#3252 (issues MudBlazor#3701 MudBlazor#3687)

* Dialog: Added InlineDialogShouldNotCloseAfterStateHasChanged test
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
…udBlazor#3752)

* Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701

* Dialog test: trying to get it to work on CI
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
…MudBlazor#3687) (MudBlazor#3760)

* Dialog: Fix regression caused by MudBlazor#3252 (issues MudBlazor#3701 MudBlazor#3687)

* Dialog: Added InlineDialogShouldNotCloseAfterStateHasChanged test
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
…udBlazor#3752)

* Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701

* Dialog test: trying to get it to work on CI
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
…MudBlazor#3687) (MudBlazor#3760)

* Dialog: Fix regression caused by MudBlazor#3252 (issues MudBlazor#3701 MudBlazor#3687)

* Dialog: Added InlineDialogShouldNotCloseAfterStateHasChanged test
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
…udBlazor#3752)

* Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701

* Dialog test: trying to get it to work on CI
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
…MudBlazor#3687) (MudBlazor#3760)

* Dialog: Fix regression caused by MudBlazor#3252 (issues MudBlazor#3701 MudBlazor#3687)

* Dialog: Added InlineDialogShouldNotCloseAfterStateHasChanged test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudDialog class property is ignored.
4 participants