-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table: Fixed incorrect async code path for label sorting #3352
Conversation
Fixed double server load callback when changing sorting
Codecov Report
@@ Coverage Diff @@
## dev #3352 +/- ##
==========================================
+ Coverage 89.71% 89.77% +0.05%
==========================================
Files 312 312
Lines 9507 9503 -4
==========================================
+ Hits 8529 8531 +2
+ Misses 978 972 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you please also add a bUnit test?
Added a couple of tests to count the number of callbacks used. |
src/MudBlazor.UnitTests.Viewer/TestComponents/Table/TableServerSideDataTest5.razor
Outdated
Show resolved
Hide resolved
…rSideDataTest5.razor Co-authored-by: Jonas B. <62108893+JonBunator@users.noreply.github.com>
Co-authored-by: Jonas B. <62108893+JonBunator@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks
@JonBunator just out of curiosity, could you please comment on the |
Description
This PR fixes incorrect usage of async code path when clicking
MudTable
labels to sort data.Also fixed double callback for
ServerData
in the same case.How Has This Been Tested?
All standard tests apply and passed.
Types of changes
Checklist:
dev
).This PR was created based on 5.2.0 tag.