Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressLinear: Several new features, fixed bad examples and added new, code cleanup #3383

Merged
merged 8 commits into from
Nov 19, 2021
Merged

ProgressLinear: Several new features, fixed bad examples and added new, code cleanup #3383

merged 8 commits into from
Nov 19, 2021

Conversation

Garderoben
Copy link
Member

@Garderoben Garderoben commented Nov 17, 2021

Description

Will add tests for this before merge.

  • Removed unused parameters
  • Removed unused CSS
  • Fixed so all colors works in all different modes
  • Fixed buffer mode
  • Added missing comments on parameters
  • Added missing default color
  • Added Size option
  • Added Rounded option
  • Added Striped option
  • Added ChildContent option
  • Added Vertical option

Default Color

DefaultColor

buffer
Size
Rounded
Striped
Labels
Vertical

How Has This Been Tested?

Just Manually so far, need to add tests

Checklist:

✔️ The PR is submitted to the correct branch (dev).
✔️ My code follows the code style of this project.
❌ I've added relevant tests.

@mudbot mudbot bot added bug Something does not work as intended/expected enhancement New feature or request needs review labels Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #3383 (451c037) into dev (9619ef1) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3383      +/-   ##
==========================================
+ Coverage   89.71%   89.80%   +0.09%     
==========================================
  Files         312      313       +1     
  Lines        9505     9505              
==========================================
+ Hits         8527     8536       +9     
+ Misses        978      969       -9     
Impacted Files Coverage Δ
...azor/Components/Progress/MudProgressCircular.razor 100.00% <ø> (ø)
...r/Components/Progress/MudProgressCircular.razor.cs 92.85% <100.00%> (+4.39%) ⬆️
...Blazor/Components/Progress/MudProgressLinear.razor 100.00% <100.00%> (ø)
...zor/Components/Progress/MudProgressLinear.razor.cs 100.00% <100.00%> (+4.34%) ⬆️
src/MudBlazor/Extensions/DoubleExtentions.cs 100.00% <100.00%> (ø)
src/MudBlazor/Components/Table/TableContext.cs 98.50% <0.00%> (ø)
...Blazor/Components/Table/MudTableSortLabel.razor.cs 91.17% <0.00%> (+2.28%) ⬆️
src/MudBlazor/Components/Input/MudInput.razor.cs 85.45% <0.00%> (+3.63%) ⬆️
src/MudBlazor/Extensions/TaskExtensions.cs 55.55% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9619ef1...451c037. Read the comment docs.

@Garderoben
Copy link
Member Author

@just-the-benno the champ added some tests and cleaned code even more!

@Garderoben Garderoben added this to the 6.0.3 milestone Nov 19, 2021
@Garderoben Garderoben merged commit 5abb75f into MudBlazor:dev Nov 19, 2021
@Yomodo
Copy link
Contributor

Yomodo commented Nov 20, 2021

The last progress bar (animated stripes) from the "Linear Vertical" example has its animation going backward instead of forward.

@Garderoben Garderoben deleted the progress-cleanup branch March 17, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants