Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating: Keyboard Navigation #3399

Merged
merged 4 commits into from
Nov 19, 2021
Merged

Rating: Keyboard Navigation #3399

merged 4 commits into from
Nov 19, 2021

Conversation

mckaragoz
Copy link
Member

@mckaragoz mckaragoz commented Nov 19, 2021

Description

Rating now has keyboard navigation.
Details:

Keyboard navigation
Focused style like the checkbox (only tab focus has style, mouse click focus not)
Docs
Test

How Has This Been Tested?

20211119_135745.mp4

Checklist:

✔️ The PR is submitted to the correct branch (dev).
✔️ My code follows the code style of this project.
✔️ I've added relevant tests.

@mudbot mudbot bot added enhancement New feature or request needs review labels Nov 19, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #3399 (d5aeae7) into dev (36548fb) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3399      +/-   ##
==========================================
+ Coverage   89.77%   89.89%   +0.12%     
==========================================
  Files         312      312              
  Lines        9503     9648     +145     
==========================================
+ Hits         8531     8673     +142     
- Misses        972      975       +3     
Impacted Files Coverage Δ
src/MudBlazor/Components/Rating/MudRating.razor 100.00% <ø> (ø)
...rc/MudBlazor/Components/Rating/MudRatingItem.razor 100.00% <ø> (ø)
src/MudBlazor/Components/Rating/MudRating.razor.cs 100.00% <100.00%> (+20.00%) ⬆️
...c/MudBlazor/Components/DatePicker/MudDatePicker.cs 82.75% <0.00%> (-9.84%) ⬇️
src/MudBlazor/Components/Picker/MudPicker.razor.cs 97.52% <0.00%> (-0.10%) ⬇️
src/MudBlazor/Components/Select/MudSelect.razor.cs 95.67% <0.00%> (+0.03%) ⬆️
...lazor/Components/Dialog/MudDialogProvider.razor.cs 84.84% <0.00%> (+0.47%) ⬆️
src/MudBlazor/Services/DialogService.cs 89.18% <0.00%> (+1.35%) ⬆️
...lazor/Components/TimePicker/MudTimePicker.razor.cs 97.88% <0.00%> (+1.67%) ⬆️
...udBlazor/Services/KeyInterceptor/KeyInterceptor.cs 74.19% <0.00%> (+1.77%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36548fb...d5aeae7. Read the comment docs.

@henon henon added this to the 6.0.3 milestone Nov 19, 2021
@@ -2,7 +2,7 @@
@inherits MudComponentBase


<span @attributes="UserAttributes" class="@ClassName" style="@Style" >
<span @attributes="UserAttributes" tabindex="@(Disabled?-1:0)" @onkeydown="HandleKeyDown" class="@ClassName" style="@Style" >
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add this before user attributes. otherwise they can not override the tabindex

@henon henon merged commit 55b2fd7 into MudBlazor:dev Nov 19, 2021
@mckaragoz mckaragoz deleted the RatingKeyNav branch January 14, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants