Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: OnBlur Fix #3531

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Select: OnBlur Fix #3531

merged 2 commits into from
Jan 14, 2022

Conversation

mckaragoz
Copy link
Member

Description

Fixes #3469. Added missing base call in select OnBlur event.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
20211211_133404.mp4

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests. (Already have test)

@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #3531 (97b4cb7) into dev (48107f3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 97b4cb7 differs from pull request most recent head 91443e3. Consider uploading reports for the commit 91443e3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3531      +/-   ##
==========================================
- Coverage   90.33%   90.32%   -0.01%     
==========================================
  Files         332      332              
  Lines       10435    10436       +1     
==========================================
  Hits         9426     9426              
- Misses       1009     1010       +1     
Impacted Files Coverage Δ
src/MudBlazor/Components/Select/MudSelect.razor.cs 95.44% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48107f3...91443e3. Read the comment docs.

@mckaragoz
Copy link
Member Author

@henon @mikes-gh i added a test here.

@henon henon removed the needs tests label Jan 14, 2022
@henon henon added this to the 6.0.5 milestone Jan 14, 2022
@henon henon merged commit 8f53371 into MudBlazor:dev Jan 14, 2022
@henon
Copy link
Collaborator

henon commented Jan 14, 2022

Great. Thanks!

@Garderoben Garderoben added the bug Something does not work as intended/expected label Jan 17, 2022
@mckaragoz mckaragoz deleted the SelectOnBlur branch March 26, 2022 10:10
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
* Select OnBlur Fix

* Add Test
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
* Select OnBlur Fix

* Add Test
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
* Select OnBlur Fix

* Add Test
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
* Select OnBlur Fix

* Add Test
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
* Select OnBlur Fix

* Add Test
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
* Select OnBlur Fix

* Add Test
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
* Select OnBlur Fix

* Add Test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudSelect OnBlur broken in version 6
4 participants