Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker: Fixed Values - Don't hide year / date in toolbar #3538

Merged

Conversation

steveoandrey
Copy link
Contributor

Description

Resolves visual issue with Date Picker when using Fixed Values.
It was pointed out by @Garderoben in #2990
PR contains the key part of #3490 without adding any new parameters.
Instead of hiding these displays alltogether, it is just made impossible to switch to those views (For example, the button click does not do the action

How Has This Been Tested?

Unit test were adapted to reflect the changed visuals
Manual visual tests were done.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

It is 100% non breaking, because the fixed values feature is not yet released.

Before (dev)
image
After (PR)
image

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #3538 (1bb690c) into dev (60e5bb8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3538   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files         333      333           
  Lines       10445    10445           
=======================================
  Hits         9437     9437           
  Misses       1008     1008           
Impacted Files Coverage Δ
...azor/Components/DatePicker/MudBaseDatePicker.razor 97.72% <100.00%> (-0.06%) ⬇️
...r/Components/DatePicker/MudBaseDatePicker.razor.cs 86.54% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e5bb8...1bb690c. Read the comment docs.

@mikes-gh mikes-gh changed the title DatePicker Fixed Values: Don't hide year / date in toolbar DatePicker: Fixed Values - Don't hide year / date in toolbar Dec 19, 2021
@Garderoben Garderoben added this to the 6.0.11 milestone May 7, 2022
@Garderoben Garderoben added enhancement New feature or request and removed needs review labels May 7, 2022
@Garderoben Garderoben merged commit 13a08ac into MudBlazor:dev May 7, 2022
@steveoandrey steveoandrey deleted the feature/fixed_datevalues_ui_fix branch May 7, 2022 09:08
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
ScarletKuro pushed a commit to ScarletKuro/MudBlazor that referenced this pull request Mar 27, 2023
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants