-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DatePicker: Fixed Values - Don't hide year / date in toolbar #3538
Merged
Garderoben
merged 1 commit into
MudBlazor:dev
from
steveoandrey:feature/fixed_datevalues_ui_fix
May 7, 2022
Merged
DatePicker: Fixed Values - Don't hide year / date in toolbar #3538
Garderoben
merged 1 commit into
MudBlazor:dev
from
steveoandrey:feature/fixed_datevalues_ui_fix
May 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3538 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 333 333
Lines 10445 10445
=======================================
Hits 9437 9437
Misses 1008 1008
Continue to review full report at Codecov.
|
mikes-gh
changed the title
DatePicker Fixed Values: Don't hide year / date in toolbar
DatePicker: Fixed Values - Don't hide year / date in toolbar
Dec 19, 2021
Garderoben
approved these changes
May 7, 2022
jammerware
pushed a commit
to jammerware/MudBlazor
that referenced
this pull request
Sep 20, 2022
jammerware
pushed a commit
to jammerware/MudBlazor
that referenced
this pull request
Sep 20, 2022
jammerware
pushed a commit
to jammerware/MudBlazor
that referenced
this pull request
Sep 20, 2022
jammerware
pushed a commit
to jammerware/MudBlazor
that referenced
this pull request
Sep 20, 2022
3dots
pushed a commit
to 3dots/MudBlazor
that referenced
this pull request
Mar 23, 2023
ScarletKuro
pushed a commit
to ScarletKuro/MudBlazor
that referenced
this pull request
Mar 27, 2023
ferraridavide
pushed a commit
to ferraridavide/MudBlazor
that referenced
this pull request
May 30, 2023
ilovepilav
pushed a commit
to ilovepilav/MudBlazor
that referenced
this pull request
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves visual issue with Date Picker when using Fixed Values.
It was pointed out by @Garderoben in #2990
PR contains the key part of #3490 without adding any new parameters.
Instead of hiding these displays alltogether, it is just made impossible to switch to those views (For example, the button click does not do the action
How Has This Been Tested?
Unit test were adapted to reflect the changed visuals
Manual visual tests were done.
Types of changes
It is 100% non breaking, because the fixed values feature is not yet released.
Before (dev)
After (PR)
Checklist:
dev
).