Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField: Add HTML5 input types #3613

Merged
merged 8 commits into from
Dec 28, 2021
Merged

TextField: Add HTML5 input types #3613

merged 8 commits into from
Dec 28, 2021

Conversation

1619digital
Copy link
Contributor

@1619digital 1619digital commented Dec 24, 2021

Description

resolves #3605

How Has This Been Tested?

none

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Copy link
Member

@JonBunator JonBunator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Can you please expand the labels for them? Otherwise, they don't look good:

types

Also, can you please add some examples to the docs. Maybe a native input section.
Merry christmas!

@JonBunator JonBunator added enhancement New feature or request needs changes labels Dec 24, 2021
@1619digital
Copy link
Contributor Author

I have done that, with some basic examples of how different input types look. Hope that suffices for now.

Merry Christmas!

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #3613 (b474f1e) into dev (e8a6c63) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3613   +/-   ##
=======================================
  Coverage   90.36%   90.37%           
=======================================
  Files         333      333           
  Lines       10474    10482    +8     
=======================================
+ Hits         9465     9473    +8     
  Misses       1009     1009           
Impacted Files Coverage Δ
src/MudBlazor/Components/Input/MudInput.razor.cs 87.30% <100.00%> (+0.41%) ⬆️
...c/MudBlazor/Components/Tooltip/MudTooltip.razor.cs 92.50% <0.00%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a6c63...b474f1e. Read the comment docs.

1619digital and others added 6 commits December 28, 2021 11:20
Co-authored-by: Jonas B. <62108893+JonBunator@users.noreply.github.com>
Co-authored-by: Jonas B. <62108893+JonBunator@users.noreply.github.com>
Co-authored-by: Jonas B. <62108893+JonBunator@users.noreply.github.com>
…ldNativeInputsExample.razor

Co-authored-by: Jonas B. <62108893+JonBunator@users.noreply.github.com>
@JonBunator JonBunator changed the title Enhanced HTML5 input types TextField: Add HTML5 input types Dec 28, 2021
Copy link
Member

@JonBunator JonBunator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@JonBunator JonBunator added this to the 6.0.3 milestone Dec 28, 2021
@JonBunator JonBunator merged commit 4a62dc6 into MudBlazor:dev Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider extending InputTypes for more HTML5 input types
3 participants