Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumericField: Don't allow MouseWheel when Readonly/Disabled #3656

Merged

Conversation

jcambert
Copy link
Contributor

@jcambert jcambert commented Jan 3, 2022

fixes #3642 Correct MouseWheel Handler when component Disabled or Readonly

@mudbot mudbot bot added the needs review label Jan 3, 2022
@jcambert jcambert closed this Jan 3, 2022
@jcambert jcambert reopened this Jan 3, 2022
@henon henon removed the needs review label Jan 8, 2022
Copy link
Collaborator

@henon henon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NumericField code change is solid.

@henon henon changed the title Correct Readonly/Disable OnMouseWheel Handler NumericField: Don't allow MouseWheel when Readonly/Disabled Jan 8, 2022
Restoring old file
I have not seen that this .csproj was modified by visual studio 2022
@henon
Copy link
Collaborator

henon commented Jan 9, 2022

Could you please merge dev and push? Need to find out why the tests continue to fail.

@jcambert
Copy link
Contributor Author

jcambert commented Jan 9, 2022

Could you please merge dev and push? Need to find out why the tests continue to fail.

done.

@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #3656 (7e4d5e4) into dev (54ad9fd) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3656      +/-   ##
==========================================
+ Coverage   90.44%   90.49%   +0.05%     
==========================================
  Files         333      332       -1     
  Lines       10546    10494      -52     
==========================================
- Hits         9538     9497      -41     
+ Misses       1008      997      -11     
Impacted Files Coverage Δ
...r/Components/NumericField/MudNumericField.razor.cs 97.77% <100.00%> (+0.42%) ⬆️
...nts/PageContentNavigation/MudPageContentSection.cs 84.21% <0.00%> (-15.79%) ⬇️
...ontentNavigation/MudPageContentNavigation.razor.cs 95.65% <0.00%> (-1.65%) ⬇️
...geContentNavigation/MudPageContentNavigation.razor 100.00% <0.00%> (ø)
...es/BindingConverters/NumericBoundariesConverter.cs
...Components/ThemeProvider/MudThemeProvider.razor.cs 98.93% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ad9fd...7e4d5e4. Read the comment docs.

@henon henon merged commit 3ef1204 into MudBlazor:dev Jan 9, 2022
@henon
Copy link
Collaborator

henon commented Jan 9, 2022

Thanks!

@henon henon added this to the 6.0.5 milestone Jan 9, 2022
@henon henon added bug Something does not work as intended/expected bug-functional labels Jan 9, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…r#3656)

* Correct Readonly/Disable OnMouseWheel Handler

* restore old files

Restoring old file
I have not seen that this .csproj was modified by visual studio 2022

* restore dev csproj
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…r#3656)

* Correct Readonly/Disable OnMouseWheel Handler

* restore old files

Restoring old file
I have not seen that this .csproj was modified by visual studio 2022

* restore dev csproj
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…r#3656)

* Correct Readonly/Disable OnMouseWheel Handler

* restore old files

Restoring old file
I have not seen that this .csproj was modified by visual studio 2022

* restore dev csproj
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…r#3656)

* Correct Readonly/Disable OnMouseWheel Handler

* restore old files

Restoring old file
I have not seen that this .csproj was modified by visual studio 2022

* restore dev csproj
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
…r#3656)

* Correct Readonly/Disable OnMouseWheel Handler

* restore old files

Restoring old file
I have not seen that this .csproj was modified by visual studio 2022

* restore dev csproj
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
…r#3656)

* Correct Readonly/Disable OnMouseWheel Handler

* restore old files

Restoring old file
I have not seen that this .csproj was modified by visual studio 2022

* restore dev csproj
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
…r#3656)

* Correct Readonly/Disable OnMouseWheel Handler

* restore old files

Restoring old file
I have not seen that this .csproj was modified by visual studio 2022

* restore dev csproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudNumericField MouseWheel on Readonly/Disabled
3 participants