Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge: Fixed default color #3971

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Badge: Fixed default color #3971

merged 1 commit into from
Feb 16, 2022

Conversation

Garderoben
Copy link
Member

Description

When no color was set or Default Color was used the badge did not have any background color at all.
Added color to the badge if default color is used.

Before:
image

After:
image

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@Garderoben Garderoben added the bug Something does not work as intended/expected label Feb 16, 2022
@Garderoben Garderoben added this to the 6.0.7 milestone Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #3971 (068b2d4) into dev (8f24a0b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3971   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files         351      351           
  Lines       11605    11606    +1     
=======================================
+ Hits        10575    10576    +1     
  Misses       1030     1030           
Impacted Files Coverage Δ
src/MudBlazor/Components/Badge/MudBadge.razor.cs 89.28% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f24a0b...068b2d4. Read the comment docs.

@Garderoben Garderoben merged commit 7ec1f41 into MudBlazor:dev Feb 16, 2022
@Garderoben Garderoben deleted the feature/badge-defaultcolor branch March 17, 2022 07:30
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant