Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predefined Regex Masks: Add Whitespace Filter & Placeholder to IPv4 and IPv6 #4048

Merged
merged 7 commits into from
Feb 28, 2022
Merged

Predefined Regex Masks: Add Whitespace Filter & Placeholder to IPv4 and IPv6 #4048

merged 7 commits into from
Feb 28, 2022

Conversation

jcphlux
Copy link
Contributor

@jcphlux jcphlux commented Feb 26, 2022

Description

Added Whitespace Filter to Predefined Regex Masks & added custom masking to IPv4 and IPv6.
resolves #4046

How Has This Been Tested?

Added Unit test to cover all changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@codecov
Copy link

codecov bot commented Feb 26, 2022 •
edited
Loading

Codecov Report

Merging #4048 (f02a421) into dev (a170918) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4048      +/-   ##
==========================================
- Coverage   91.13%   91.11%   -0.02%     
==========================================
  Files         351      351              
  Lines       11625    11617       -8     
==========================================
- Hits        10594    10585       -9     
- Misses       1031     1032       +1
Impacted Files Coverage Δ
...rc/MudBlazor/Utilities/MaskAlgorithms/RegexMask.cs 100.00% <100.00%> (ø)
...MudBlazor/Components/DataGrid/MudDataGrid.razor.cs 91.56% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a170918...f02a421. Read the comment docs.

@jcphlux
Copy link
Contributor Author

jcphlux commented Feb 28, 2022

@henon Can we get this in the next release. I am wanting to get these changes in my next release so I don't have a workaround being published.

@henon henon changed the title Added Whitespace Filter to Predefined Regex Masks & added custom masking to IPv4 and IPv6 Predefined Regex Masks: Add Whitespace Filter & Placeholder to IPv4 and IPv6 Feb 28, 2022
@henon
Copy link
Collaborator

henon commented Feb 28, 2022

Looking good

@henon henon merged commit 1714349 into MudBlazor:dev Feb 28, 2022
@henon henon added this to the 6.0.8 milestone Feb 28, 2022
@henon henon added bug Something does not work as intended/expected bug-functional enhancement New feature or request labels Feb 28, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
@jcphlux @jammerware
Predefined Regex Masks: Add Whitespace Filter & Placeholder to IPv4 a…
d9c87a0 
…nd IPv6 (MudBlazor#4048)

* add Email RegexMask

* corrected line spacing

* regex optimization

* Added Tests for WhiteSpace to IPv4, IPv6 and Email Mask Tests
Added custom masking character to IPv4 and IPv6 Masks
Added WhiteSpaceFilter to IPv4, IPv6 and Email Masks

Co-authored-by: John Cutburth <john.cutburth@cerner.com>
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
@jcphlux @jammerware
Predefined Regex Masks: Add Whitespace Filter & Placeholder to IPv4 a…
dc79bd3 
…nd IPv6 (MudBlazor#4048)

* add Email RegexMask

* corrected line spacing

* regex optimization

* Added Tests for WhiteSpace to IPv4, IPv6 and Email Mask Tests
Added custom masking character to IPv4 and IPv6 Masks
Added WhiteSpaceFilter to IPv4, IPv6 and Email Masks

Co-authored-by: John Cutburth <john.cutburth@cerner.com>
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
@jcphlux @jammerware
Predefined Regex Masks: Add Whitespace Filter & Placeholder to IPv4 a…
33ff274 
…nd IPv6 (MudBlazor#4048)

* add Email RegexMask

* corrected line spacing

* regex optimization

* Added Tests for WhiteSpace to IPv4, IPv6 and Email Mask Tests
Added custom masking character to IPv4 and IPv6 Masks
Added WhiteSpaceFilter to IPv4, IPv6 and Email Masks

Co-authored-by: John Cutburth <john.cutburth@cerner.com>
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
@jcphlux @jammerware
Predefined Regex Masks: Add Whitespace Filter & Placeholder to IPv4 a…
f13108f 
…nd IPv6 (MudBlazor#4048)

* add Email RegexMask

* corrected line spacing

* regex optimization

* Added Tests for WhiteSpace to IPv4, IPv6 and Email Mask Tests
Added custom masking character to IPv4 and IPv6 Masks
Added WhiteSpaceFilter to IPv4, IPv6 and Email Masks

Co-authored-by: John Cutburth <john.cutburth@cerner.com>
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
@jcphlux @3dots
Predefined Regex Masks: Add Whitespace Filter & Placeholder to IPv4 a…
c59cc70 
…nd IPv6 (MudBlazor#4048)

* add Email RegexMask

* corrected line spacing

* regex optimization

* Added Tests for WhiteSpace to IPv4, IPv6 and Email Mask Tests
Added custom masking character to IPv4 and IPv6 Masks
Added WhiteSpaceFilter to IPv4, IPv6 and Email Masks

Co-authored-by: John Cutburth <john.cutburth@cerner.com>
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
@jcphlux @ferraridavide
Predefined Regex Masks: Add Whitespace Filter & Placeholder to IPv4 a…
fc40891 
…nd IPv6 (MudBlazor#4048)

* add Email RegexMask

* corrected line spacing

* regex optimization

* Added Tests for WhiteSpace to IPv4, IPv6 and Email Mask Tests
Added custom masking character to IPv4 and IPv6 Masks
Added WhiteSpaceFilter to IPv4, IPv6 and Email Masks

Co-authored-by: John Cutburth <john.cutburth@cerner.com>
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
@jcphlux @ilovepilav
Predefined Regex Masks: Add Whitespace Filter & Placeholder to IPv4 a…
7211707 
…nd IPv6 (MudBlazor#4048)

* add Email RegexMask

* corrected line spacing

* regex optimization

* Added Tests for WhiteSpace to IPv4, IPv6 and Email Mask Tests
Added custom masking character to IPv4 and IPv6 Masks
Added WhiteSpaceFilter to IPv4, IPv6 and Email Masks

Co-authored-by: John Cutburth <john.cutburth@cerner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something does not work as intended/expected enhancement New feature or request
Projects
None yet
Milestone
6.0.8
Development

Successfully merging this pull request may close these issues.

Predefined Regex Mask allowing newline in value
2 participants
@jcphlux @henon