Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu and Select: Fix not close on mobile view #4112

Merged
merged 5 commits into from Mar 6, 2022

Conversation

mckaragoz
Copy link
Member

@mckaragoz mckaragoz commented Mar 6, 2022

Description

Fixed #4063. Added touch events.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@mckaragoz mckaragoz changed the title Menu and Select: Fix not open on mobile view Menu and Select: Fix not close on mobile view Mar 6, 2022
@Garderoben Garderoben self-requested a review March 6, 2022 14:16
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #4112 (92afffd) into dev (1c9eebd) will decrease coverage by 0.01%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4112      +/-   ##
==========================================
- Coverage   89.66%   89.65%   -0.02%     
==========================================
  Files         357      357              
  Lines       12304    12321      +17     
==========================================
+ Hits        11032    11046      +14     
- Misses       1272     1275       +3     
Impacted Files Coverage Δ
src/MudBlazor/Components/Menu/MudMenu.razor 100.00% <ø> (ø)
src/MudBlazor/Components/Menu/MudMenuItem.razor 100.00% <ø> (ø)
...rc/MudBlazor/Components/Select/MudSelectItem.razor 100.00% <ø> (ø)
src/MudBlazor/Components/Menu/MudMenuItem.razor.cs 81.81% <81.81%> (ø)
src/MudBlazor/Components/Menu/MudMenu.razor.cs 73.91% <83.33%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c9eebd...92afffd. Read the comment docs.

@Garderoben Garderoben added bug Something does not work as intended/expected needs tests labels Mar 6, 2022
@Garderoben
Copy link
Member

@mckaragoz looks good now, just need tests.

@mckaragoz
Copy link
Member Author

@Garderoben tests are ready

@Garderoben Garderoben added this to the 6.0.8 milestone Mar 6, 2022
@Garderoben Garderoben merged commit c8b0d9b into MudBlazor:dev Mar 6, 2022
@mckaragoz mckaragoz deleted the MenuSelectMobile branch March 26, 2022 10:06
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…4112)

* Menu and Select: Fix not open on mobile view

* Refactor if block

* Test

* More Test Conditions

* Last Conditions
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…4112)

* Menu and Select: Fix not open on mobile view

* Refactor if block

* Test

* More Test Conditions

* Last Conditions
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…4112)

* Menu and Select: Fix not open on mobile view

* Refactor if block

* Test

* More Test Conditions

* Last Conditions
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
…4112)

* Menu and Select: Fix not open on mobile view

* Refactor if block

* Test

* More Test Conditions

* Last Conditions
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
…4112)

* Menu and Select: Fix not open on mobile view

* Refactor if block

* Test

* More Test Conditions

* Last Conditions
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
…4112)

* Menu and Select: Fix not open on mobile view

* Refactor if block

* Test

* More Test Conditions

* Last Conditions
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
…4112)

* Menu and Select: Fix not open on mobile view

* Refactor if block

* Test

* More Test Conditions

* Last Conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudSelect don't close dropdown when you select an item (on small screens, BSS only)
2 participants