Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropZone: Added built in reordering #4179

Merged
merged 23 commits into from Mar 18, 2022
Merged

DropZone: Added built in reordering #4179

merged 23 commits into from Mar 18, 2022

Conversation

Garderoben
Copy link
Member

@Garderoben Garderoben commented Mar 14, 2022

Description

Added built in functionality for reordering of items inside drop zones.
Added possibility to have DropZones only act as zones and not display any items.
Added example on how saving the reordered items can be done.
Added example on how one can use the OnlyZone options to build FileExplorer/Mail Client like UI's.

Mostly made by @just-the-benno and little me.

GitHubReorder1
GitHubReorder2

How Has This Been Tested?

Tests added, tested in Wasm/Server and manually testing during development.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@Garderoben Garderoben added the enhancement New feature or request label Mar 14, 2022
@Garderoben Garderoben added this to the 6.0.8 milestone Mar 14, 2022
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #4179 (a75dd61) into dev (5b4c19d) will decrease coverage by 0.03%.
The diff coverage is 97.82%.

@@            Coverage Diff             @@
##              dev    #4179      +/-   ##
==========================================
- Coverage   90.03%   90.00%   -0.04%     
==========================================
  Files         358      359       +1     
  Lines       12327    12449     +122     
==========================================
+ Hits        11099    11205     +106     
- Misses       1228     1244      +16     
Impacted Files Coverage Δ
src/MudBlazor/Attributes/CategoryAttribute.cs 96.22% <ø> (ø)
...or/Components/DropZone/MudDynamicDropItem.razor.cs 96.29% <80.00%> (-3.71%) ⬇️
...azor/Components/DropZone/MudDropContainer.razor.cs 97.43% <96.36%> (-2.57%) ⬇️
...rc/MudBlazor/Components/DropZone/MudDropZone.razor 100.00% <100.00%> (ø)
...MudBlazor/Components/DropZone/MudDropZone.razor.cs 98.41% <100.00%> (+0.65%) ⬆️
...lazor/Components/DropZone/MudDynamicDropItem.razor 100.00% <100.00%> (ø)
src/MudBlazor/Utilities/SortingAssistent.cs 100.00% <100.00%> (ø)
src/MudBlazor/Services/JsApiService.cs 42.85% <0.00%> (-42.86%) ⬇️
src/MudBlazor/Components/Menu/MudMenuItem.razor.cs 56.52% <0.00%> (-25.30%) ⬇️
src/MudBlazor/Base/MudBaseButton.cs 81.81% <0.00%> (-8.19%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b4c19d...a75dd61. Read the comment docs.

@Garderoben
Copy link
Member Author

Dont merge this one yet, we will make it easier to save the reordering of items.

@just-the-benno
Copy link
Contributor

I want to thank @duke-darius for the groundwork for this PR (#3946). Thanks to him and his ideas, we could speed up the development.

@Garderoben Garderoben merged commit a602d91 into MudBlazor:dev Mar 18, 2022
@duke-darius
Copy link
Contributor

I want to thank @duke-darius for the groundwork for this PR (#3946). Thanks to him and his ideas, we could speed up the development.

Yay! My pleasure :)
It's a great feature to have!

@jimitndiaye
Copy link
Contributor

Great work. I'm looking forward to the release.

jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
Co-authored-by: Aaron Griffin <aaronjgriffin96@gmail.com>
Co-authored-by: Benjamin Kappel <b.kappel90@outlook.de>
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
Co-authored-by: Aaron Griffin <aaronjgriffin96@gmail.com>
Co-authored-by: Benjamin Kappel <b.kappel90@outlook.de>
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
Co-authored-by: Aaron Griffin <aaronjgriffin96@gmail.com>
Co-authored-by: Benjamin Kappel <b.kappel90@outlook.de>
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
Co-authored-by: Aaron Griffin <aaronjgriffin96@gmail.com>
Co-authored-by: Benjamin Kappel <b.kappel90@outlook.de>
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
Co-authored-by: Aaron Griffin <aaronjgriffin96@gmail.com>
Co-authored-by: Benjamin Kappel <b.kappel90@outlook.de>
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
Co-authored-by: Aaron Griffin <aaronjgriffin96@gmail.com>
Co-authored-by: Benjamin Kappel <b.kappel90@outlook.de>
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Co-authored-by: Aaron Griffin <aaronjgriffin96@gmail.com>
Co-authored-by: Benjamin Kappel <b.kappel90@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants