-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select: Required now also works when MultiSelection="true" (#4328, #4346) #4346
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4346 +/- ##
==========================================
- Coverage 91.22% 91.17% -0.05%
==========================================
Files 361 361
Lines 12450 12461 +11
==========================================
+ Hits 11357 11361 +4
- Misses 1093 1100 +7
Continue to review full report at Codecov.
|
Please wait on merge. I have fixed a typo in the test and need add two more checks to the test to show that the required error is not present when MultiSelect has value(s). Standby by please |
Ready for review :) |
Looking good for me |
Perfect! Thanks |
Description
Fixes #4328
MudSelect When Required=true and MultiSelection=true Required Value check now works. Fixed by overriding
HasValue
method in MudSelect.How Has This Been Tested?
Test Added To SelectTests
MultiSelectWithRequiredValue
Types of changes
Checklist:
dev
).