Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List: Added selected color & fixed parent null issue #4411

Merged
merged 4 commits into from Apr 13, 2022
Merged

List: Added selected color & fixed parent null issue #4411

merged 4 commits into from Apr 13, 2022

Conversation

Garderoben
Copy link
Member

Description

I remade @mckaragoz PR #4329 as it broke the hover and had wrong selected color by default. But mostly i did it to implement the usage the utility classes instead of adding more component specific CSS that we already have.

The docs Example is copied from @mckaragoz PR.
Also fixes a null issue with MudListItem when using Nested list and no parent List is present.

@mckaragoz sorry that i highjacked your PR but after i reviewed it and tested it, it was just so much faster for me to do it myself than show you/explain, please take your time and see what i did differently and especially for the ColorTest i added.

ListColor

How Has This Been Tested?

unit | visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@Garderoben Garderoben added bug Something does not work as intended/expected enhancement New feature or request labels Apr 13, 2022
@Garderoben Garderoben added this to the 6.0.10 milestone Apr 13, 2022
@Garderoben Garderoben mentioned this pull request Apr 13, 2022
6 tasks
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #4411 (d3a14f1) into dev (11dcc7d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #4411      +/-   ##
==========================================
+ Coverage   91.17%   91.18%   +0.01%     
==========================================
  Files         361      361              
  Lines       12459    12466       +7     
==========================================
+ Hits        11359    11367       +8     
+ Misses       1100     1099       -1     
Impacted Files Coverage Δ
src/MudBlazor/Components/List/MudList.razor.cs 96.42% <ø> (ø)
src/MudBlazor/Components/List/MudListItem.razor 100.00% <ø> (ø)
src/MudBlazor/Components/Switch/MudSwitch.razor 100.00% <ø> (ø)
...MudBlazor/Components/Button/MudIconButton.razor.cs 100.00% <100.00%> (ø)
...MudBlazor/Components/CheckBox/MudCheckBox.razor.cs 100.00% <100.00%> (ø)
src/MudBlazor/Components/List/MudListItem.razor.cs 82.25% <100.00%> (ø)
src/MudBlazor/Components/Radio/MudRadio.razor.cs 100.00% <100.00%> (ø)
src/MudBlazor/Components/Switch/MudSwitch.razor.cs 100.00% <100.00%> (ø)
...r/Components/Autocomplete/MudAutocomplete.razor.cs 91.62% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6646c28...d3a14f1. Read the comment docs.

@Garderoben Garderoben merged commit 760a596 into MudBlazor:dev Apr 13, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
* List: Added selected color & fixed parent null issue
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
* List: Added selected color & fixed parent null issue
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
* List: Added selected color & fixed parent null issue
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
* List: Added selected color & fixed parent null issue
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
* List: Added selected color & fixed parent null issue
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
* List: Added selected color & fixed parent null issue
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
* List: Added selected color & fixed parent null issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant