Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavMenu: Fix border stle for RTL layout #4425

Merged
merged 4 commits into from
Apr 23, 2022
Merged

NavMenu: Fix border stle for RTL layout #4425

merged 4 commits into from
Apr 23, 2022

Conversation

vrassouli
Copy link
Contributor

Fixed the border style alignment of the NavMenu

Description

Border style was set to right edge by using
border-right-style: solid; border-right-width: 2px;
It's now fixed by using inline styles of the border:
border-inline-end-style: solid; border-inline-end-width: 2px;

How Has This Been Tested?

visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Before:
image

After:
image

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@vrassouli
Copy link
Contributor Author

Hi team,
I'm new to MudBlazor
I appreciate you for the great job

As I'm working mostly on RTL projects, I see some issues at this area around MudBlazor.
If I'm allowed, I can work on some of these issues as much as I can.

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #4425 (133e4cd) into dev (3d5ac04) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #4425      +/-   ##
==========================================
- Coverage   91.22%   91.21%   -0.01%     
==========================================
  Files         361      361              
  Lines       12473    12473              
==========================================
- Hits        11378    11377       -1     
- Misses       1095     1096       +1     
Impacted Files Coverage Δ
...azor/Components/InputControl/MudInputControl.razor 100.00% <ø> (ø)
...r/Components/Autocomplete/MudAutocomplete.razor.cs 91.16% <0.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5ac04...133e4cd. Read the comment docs.

@zubairkhakwani
Copy link

@vrassouli can you please check my PR why it's failing to build & Test, I've just changed a single line in CSS and it's not a breaking change. It would be very helpful for me if you can help. Thanks

#4451

@vrassouli
Copy link
Contributor Author

I checked it, but founding nothing!
By adding your changes to my local repo, all test get passed without errors! can not understand what is wrong with the pipeline

@zubairkhakwani
Copy link

@vrassouli okay thank you.

Copy link
Member

@JonBunator JonBunator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks :)

@JonBunator JonBunator added this to the 6.0.10 milestone Apr 23, 2022
@JonBunator JonBunator added the bug Something does not work as intended/expected label Apr 23, 2022
@JonBunator JonBunator merged commit b073acf into MudBlazor:dev Apr 23, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants