Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: Make GetFullPathOfMember method public #4791

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

Mr-Technician
Copy link
Member

Description

GetFullPathOfMember under ExpressionExtensions is currently internal, meaning it cannot be used for custom IFormComponent implementations. This is a very niche usage but I am working on an adaptation of TinyMCE.Blazor and need the component to implement IFormComponent as well as use fluent validation. At present, I must copy this entire extension method in order to use it in my project. The other utilities are public, so I don't think there is a good reason for this one to be internal.

How Has This Been Tested?

Not applicable

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
@Mr-Technician Mr-Technician changed the title Make GetFullPathOfMember method public Extensions: Make GetFullPathOfMember method public Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #4791 (3a28221) into dev (209b474) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #4791   +/-   ##
=======================================
  Coverage   91.41%   91.42%           
=======================================
  Files         365      365           
  Lines       12542    12542           
=======================================
+ Hits        11465    11466    +1     
+ Misses       1077     1076    -1     
Impacted Files Coverage Δ
src/MudBlazor/Utilities/ExpressionExtensions.cs 100.00% <ø> (ø)
...r/Components/Autocomplete/MudAutocomplete.razor.cs 94.73% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209b474...3a28221. Read the comment docs.

@Mr-Technician
Copy link
Member Author

@henon Can you peek at this? It's really simple. :)

@henon henon merged commit 0a4bd93 into MudBlazor:dev Jun 28, 2022
@henon henon added the API change API that needs approval label Jun 28, 2022
@henon henon added this to the 6.0.11 milestone Jun 28, 2022
@Mr-Technician Mr-Technician deleted the patch-1 branch June 28, 2022 13:16
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
ScarletKuro pushed a commit to ScarletKuro/MudBlazor that referenced this pull request Mar 27, 2023
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change API that needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants