-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions: Make GetFullPathOfMember method public #4791
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
Mr-Technician
changed the title
Make GetFullPathOfMember method public
Extensions: Make GetFullPathOfMember method public
Jun 27, 2022
Codecov Report
@@ Coverage Diff @@
## dev #4791 +/- ##
=======================================
Coverage 91.41% 91.42%
=======================================
Files 365 365
Lines 12542 12542
=======================================
+ Hits 11465 11466 +1
+ Misses 1077 1076 -1
Continue to review full report at Codecov.
|
@henon Can you peek at this? It's really simple. :) |
jammerware
pushed a commit
to jammerware/MudBlazor
that referenced
this pull request
Sep 20, 2022
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
jammerware
pushed a commit
to jammerware/MudBlazor
that referenced
this pull request
Sep 20, 2022
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
jammerware
pushed a commit
to jammerware/MudBlazor
that referenced
this pull request
Sep 20, 2022
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
jammerware
pushed a commit
to jammerware/MudBlazor
that referenced
this pull request
Sep 20, 2022
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
3dots
pushed a commit
to 3dots/MudBlazor
that referenced
this pull request
Mar 23, 2023
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
ScarletKuro
pushed a commit
to ScarletKuro/MudBlazor
that referenced
this pull request
Mar 27, 2023
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
ferraridavide
pushed a commit
to ferraridavide/MudBlazor
that referenced
this pull request
May 30, 2023
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
ilovepilav
pushed a commit
to ilovepilav/MudBlazor
that referenced
this pull request
Nov 25, 2023
`GetFullPathOfMember` under `ExpressionExtensions` is currently internal, meaning it cannot be used for custom IFormComponent implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GetFullPathOfMember
underExpressionExtensions
is currently internal, meaning it cannot be used for customIFormComponent
implementations. This is a very niche usage but I am working on an adaptation of TinyMCE.Blazor and need the component to implementIFormComponent
as well as use fluent validation. At present, I must copy this entire extension method in order to use it in my project. The other utilities are public, so I don't think there is a good reason for this one to be internal.How Has This Been Tested?
Not applicable
Types of changes
Checklist:
dev
).