Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9511 +/- ##
==========================================
+ Coverage 89.82% 90.56% +0.73%
==========================================
Files 412 406 -6
Lines 11878 12708 +830
Branches 2364 2462 +98
==========================================
+ Hits 10670 11509 +839
+ Misses 681 638 -43
- Partials 527 561 +34 ☔ View full report in Codecov by Sentry. |
xC0dex
reviewed
Jul 26, 2024
| #if NET8_0_OR_GREATER | ||
| var parametersHandlerShouldFire = _parameterScopeContainers.SelectMany(parameter => parameter) | ||
| .Where(parameter => parameter.HasHandler && parameter.HasParameterChanged(parameters)) | ||
| .ToFrozenSet(ParameterHandlerUniquenessComparer.Default); |
Member
There was a problem hiding this comment.
Side note: I think the FrozenSet is not the best type here to be used compared to Hashset because it requires more time and allocations to be created.
| Method | Mean | Error | StdDev | Ratio | RatioSD | Allocated | Alloc Ratio |
|---|---|---|---|---|---|---|---|
| ToHashSet | 2.242 us | 0.0150 us | 0.0125 us | 1.00 | 0.00 | 2.23 KB | 1.00 |
| ToFrozenSet | 48.176 us | 0.1614 us | 0.1431 us | 21.48 | 0.14 | 12.45 KB | 5.57 |
Member
There was a problem hiding this comment.
I guess it makes sense to have HashSet in this place as we just enumerate it and we do not do read individual values where the FrozenSet is faster.
Member
Member
|
Sticky note: |
ScarletKuro
approved these changes
Oct 10, 2024
Contributor
|
Thanks @danielchalmers ! Work on v8 is now officially commencing! |
Closed
Member
|
Added to v8.0.0 Migration Guide #9953 |
3 tasks
2 tasks
LLauter
pushed a commit
to cannellamedia/MudBlazor
that referenced
this pull request
Dec 16, 2024
This was referenced Aug 18, 2025
This was referenced Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.NET 7 reached End of Support on May 14, 2024.
Todo:
MudBlazor/src/MudBlazor/Utilities/Debounce/DebounceDispatcher.cs
Lines 42 to 45 in f317083
MudBlazor/src/MudBlazor/Services/Popover/PopoverService.cs
Lines 227 to 243 in f317083
MudBlazor/src/MudBlazor/Components/ThemeProvider/MudThemeProvider.razor.cs
Lines 478 to 479 in f317083
MudBlazor/src/MudBlazor/Services/Browser/BrowserViewportService.cs
Lines 280 to 282 in f317083
MudBlazor/src/MudBlazor/Services/Popover/PopoverService.cs
Lines 238 to 243 in f317083
MudBlazor/src/MudBlazor/Utilities/AsyncKeyedLock/AsyncKeyedLocker.cs
Line 737 in f317083
How Has This Been Tested?
Type of Changes
Checklist
dev).