Skip to content

TimeSeries: Rename TimeSeriesDiplayType to fix typo#9581

Merged
henon merged 2 commits intoMudBlazor:devfrom
danielchalmers:time-series-display-type-typo
Oct 13, 2024
Merged

TimeSeries: Rename TimeSeriesDiplayType to fix typo#9581
henon merged 2 commits intoMudBlazor:devfrom
danielchalmers:time-series-display-type-typo

Conversation

@danielchalmers
Copy link
Member

Description

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Aug 7, 2024
@codecov
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.80%. Comparing base (28bc599) to head (0de4eac).
Report is 564 commits behind head on dev.

Files with missing lines Patch % Lines
...Blazor/Components/Chart/Charts/TimeSeries.razor.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9581      +/-   ##
==========================================
+ Coverage   89.82%   90.80%   +0.97%     
==========================================
  Files         412      411       -1     
  Lines       11878    12844     +966     
  Branches     2364     2483     +119     
==========================================
+ Hits        10670    11663     +993     
+ Misses        681      618      -63     
- Partials      527      563      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro added v8 API change Modifies the public API surface refactor Reorganizes code and has no changes to the API or functionality in the main library and removed PR: needs review labels Aug 8, 2024
@danielchalmers danielchalmers requested a review from henon October 10, 2024 19:01
@danielchalmers danielchalmers changed the title TimeSeries: Rename TimeSeriesDiplayType to fix typo TimeSeries: Rename TimeSeriesDiplayType to fix typo Oct 10, 2024
@henon henon merged commit c904a7f into MudBlazor:dev Oct 13, 2024
@henon henon mentioned this pull request Oct 13, 2024
@ScarletKuro
Copy link
Member

Ah wasnt fast enough to close this, as it was already done in this PR: #9919

@henon
Copy link
Contributor

henon commented Oct 13, 2024

oh, in any case I added it to the v8 migration guide: #9953

LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates refactor Reorganizes code and has no changes to the API or functionality in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants