Skip to content

Conversation

@danielchalmers
Copy link
Member

Description

Resolves #9011 by making FontWeight and LineHeight of type string?.

Final CSS has not changed as evidenced by the passing tests. This should only require surrounding the previous values in double quotes to migrate to this new setup.

How Has This Been Tested?

unit

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates (apply this instead of enhancement) enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Aug 8, 2024
@codecov
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.55%. Comparing base (28bc599) to head (dd36f32).
Report is 530 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9592      +/-   ##
==========================================
+ Coverage   89.82%   90.55%   +0.72%     
==========================================
  Files         412      406       -6     
  Lines       11878    12751     +873     
  Branches     2364     2472     +108     
==========================================
+ Hits        10670    11547     +877     
+ Misses        681      642      -39     
- Partials      527      562      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro added API change Modifies the public API surface v8 and removed PR: needs review labels Aug 9, 2024
@ScarletKuro ScarletKuro merged commit 8ff593f into MudBlazor:dev Oct 10, 2024
@ScarletKuro
Copy link
Member

Added to v8.0.0 Migration Guide #9953

LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates (apply this instead of enhancement) enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typography: Allow strings in all settings

2 participants