-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Typography: Make FontWeight and LineHeight strings
#9592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9592 +/- ##
==========================================
+ Coverage 89.82% 90.55% +0.72%
==========================================
Files 412 406 -6
Lines 11878 12751 +873
Branches 2364 2472 +108
==========================================
+ Hits 10670 11547 +877
+ Misses 681 642 -39
- Partials 527 562 +35 ☔ View full report in Codecov by Sentry. |
ScarletKuro
approved these changes
Aug 9, 2024
7 tasks
Member
|
Added to v8.0.0 Migration Guide #9953 |
LLauter
pushed a commit
to cannellamedia/MudBlazor
that referenced
this pull request
Dec 16, 2024
This was referenced Aug 18, 2025
This was referenced Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API change
Modifies the public API surface
breaking change
This change will require consumer code updates (apply this instead of enhancement)
enhancement
Adds a new feature or enhances existing functionality (not fixing a defect) in the main library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9011 by making
FontWeightandLineHeightof typestring?.Final CSS has not changed as evidenced by the passing tests. This should only require surrounding the previous values in double quotes to migrate to this new setup.
How Has This Been Tested?
unit
Type of Changes
Checklist
dev).