-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
MudGlobal: Add more component defaults #9691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudGlobal: Add more component defaults #9691
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9691 +/- ##
==========================================
+ Coverage 89.82% 90.82% +0.99%
==========================================
Files 412 406 -6
Lines 11878 12825 +947
Branches 2364 2476 +112
==========================================
+ Hits 10670 11648 +978
+ Misses 681 623 -58
- Partials 527 554 +27 ☔ View full report in Codecov by Sentry. |
…defaults' into feature/new-mudglobal-component-defaults
danielchalmers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! One small typo I noticed
| /// </summary> | ||
| [Parameter] | ||
| [Category(CategoryTypes.Tabs.Appearance)] | ||
| public bool Outlined { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you overlook this or is there a reason for not including it in MudGlobal?
|
I would love an automated unit test using reflection for this. The idea is as follows:
We already have an automated unit test that instantiates all components to make sure that they do not raise an exception. You could copy that test and reuse its logic for this. |
|
What's the status of this? Are we waiting the test proposed by @henon? |
|
No it is not necessary and to be honest might be harder to do than I thought. Merging now. |
|
Thanks @swatkinson |
|
Hey! Nice job here. Do you plan to also add Variant ? That would be of great help. |
Co-authored-by: Spencer Watkinson <spencer.watkinson@caivan.com> (cherry picked from commit 5403f08)
Co-authored-by: Spencer Watkinson <spencer.watkinson@caivan.com>
Description
Updated the MudGlobal.cs file to include more component defaults for:
Button, Card, DataGrid, Grid, Link, Stack, and Tabs
How Has This Been Tested?
I've updated the Mudglobal defaults from the program.cs of the UnitTests.Viewer project, and verified that the changes were reflected in the components on the website visually. (Had to make changes to some component tests to make sure they didnt overwrite the global component defaults)
Button default changes, for example:

Type of Changes
Checklist
dev).