-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
MudDialog: Don't override Class param and convert BackgroundClass to getter
#9909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| private void ConfigureInstance() | ||
| { | ||
| Class = Classname; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overwriting Class is not necessary for the dialog's functionality. Class is already set to _dialog.Class. The razor only uses Classname (consistently to other components) which contains _dialog.Class.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9909 +/- ##
==========================================
+ Coverage 89.82% 90.80% +0.97%
==========================================
Files 412 411 -1
Lines 11878 12844 +966
Branches 2364 2483 +119
==========================================
+ Hits 10670 11663 +993
+ Misses 681 618 -63
- Partials 527 563 +36 ☔ View full report in Codecov by Sentry. |
Description
This PR removes
ConfigureInstance()fromMudDialogInstanceto complete my refactoring towards only using getters instead of caching state in private and protected fields as a followup to #9906 where some fields were already eliminated.The protected property
BackgroundClassis now only used as a getter instead of using it as storage. I am not sure if this is even a breaking change as it is quite unlikely that someone would have derived from MudDialogInstance. But we'll not take any risks and merge it only with v8.How Has This Been Tested?
No additional tests needed.
Type of Changes
Checklist
dev).