Skip to content

Conversation

@ScarletKuro
Copy link
Member

Description

Remove the old MudPopoverService that was decided to be kept for v7. Now it's time for it to go.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Oct 10, 2024
@codecov
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.66%. Comparing base (28bc599) to head (36a8065).
Report is 534 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9957      +/-   ##
==========================================
+ Coverage   89.82%   90.66%   +0.83%     
==========================================
  Files         412      407       -5     
  Lines       11878    12596     +718     
  Branches     2364     2457      +93     
==========================================
+ Hits        10670    11420     +750     
+ Misses        681      613      -68     
- Partials      527      563      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 655695b into MudBlazor:dev Oct 10, 2024
@ScarletKuro ScarletKuro deleted the old_popover_remove branch October 10, 2024 16:37
@ScarletKuro
Copy link
Member Author

Added to v8.0.0 Migration Guide #9953

LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This change will require consumer code updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant