-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Typography suffix to all typography classes
#9962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Typography suffix to all typography classes
#9962
Conversation
|
The build is failing, it's also not against the latest changes that gets affected by this change. |
@ScarletKuro I'm actually not sure what's wrong with it. Branch should be updated |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9962 +/- ##
==========================================
+ Coverage 89.82% 90.78% +0.95%
==========================================
Files 412 407 -5
Lines 11878 12584 +706
Branches 2364 2454 +90
==========================================
+ Hits 10670 11425 +755
+ Misses 681 598 -83
- Partials 527 561 +34 ☔ View full report in Codecov by Sentry. |
ScarletKuro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
henon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK with this change. Something should be written up for the migration guide
|
Added to v8.0.0 Migration Guide #9953 |
Description
Consistency and to avoid overly generic/simple names.
#9434 (comment)
How Has This Been Tested?
Type of Changes
Checklist
dev).