Skip to content

Conversation

@danielchalmers
Copy link
Member

Description

Consistency and to avoid overly generic/simple names.

#9434 (comment)

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Oct 10, 2024
@ScarletKuro
Copy link
Member

The build is failing, it's also not against the latest changes that gets affected by this change.

@danielchalmers
Copy link
Member Author

danielchalmers commented Oct 11, 2024

The build is failing, it's also not against the latest changes that gets affected by this change.

@ScarletKuro I'm actually not sure what's wrong with it. Branch should be updated

@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (28bc599) to head (7fbba30).
Report is 567 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9962      +/-   ##
==========================================
+ Coverage   89.82%   90.78%   +0.95%     
==========================================
  Files         412      407       -5     
  Lines       11878    12584     +706     
  Branches     2364     2454      +90     
==========================================
+ Hits        10670    11425     +755     
+ Misses        681      598      -83     
- Partials      527      561      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ScarletKuro ScarletKuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScarletKuro ScarletKuro added the v8 label Oct 11, 2024
Copy link
Contributor

@henon henon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with this change. Something should be written up for the migration guide

@ScarletKuro
Copy link
Member

Added to v8.0.0 Migration Guide #9953

@ScarletKuro ScarletKuro merged commit 76e1278 into MudBlazor:dev Oct 13, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This change will require consumer code updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants