Skip to content

EventListener: Use [JsonSourceGenerationOptions] & cleanup#9983

Merged
ScarletKuro merged 1 commit into
MudBlazor:devfrom
ScarletKuro:eventmanager
Oct 12, 2024
Merged

EventListener: Use [JsonSourceGenerationOptions] & cleanup#9983
ScarletKuro merged 1 commit into
MudBlazor:devfrom
ScarletKuro:eventmanager

Conversation

@ScarletKuro
Copy link
Copy Markdown
Member

@ScarletKuro ScarletKuro commented Oct 12, 2024

Description

Now when .net7 is dropped we can use the [JsonSourceGenerationOptions] API and not create JsonSerializerOptions instance on each OnEventOccur call. Moving it as static was not an option since it would introduce a regression: #8979

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions Bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Oct 12, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.80%. Comparing base (28bc599) to head (6ff96a4).
Report is 545 commits behind head on dev.

Files with missing lines Patch % Lines
...azor/Services/EventManager/EventListenerFactory.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9983      +/-   ##
==========================================
+ Coverage   89.82%   90.80%   +0.97%     
==========================================
  Files         412      407       -5     
  Lines       11878    12600     +722     
  Branches     2364     2453      +89     
==========================================
+ Hits        10670    11442     +772     
+ Misses        681      597      -84     
- Partials      527      561      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant