Skip to content

Popover: Hide all element overflow#9993

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
danielchalmers:popover-overflow
Oct 13, 2024
Merged

Popover: Hide all element overflow#9993
ScarletKuro merged 1 commit intoMudBlazor:devfrom
danielchalmers:popover-overflow

Conversation

@danielchalmers
Copy link
Member

Description

https://try.mudblazor.com/snippet/maGevYFcqSgjKkjX

Hides all overflow from the popover component so that a high border radius won't visibly clip through. I'm unaware of any real world uses of the previous behaviour so it could technically be considered a breaking UI change but with low consequence (simply override the overflow style).

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Take note of the hover style on the last menu item:

before

image

after

image

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Oct 12, 2024
@codecov
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.97%. Comparing base (28bc599) to head (2988cff).
Report is 1103 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9993      +/-   ##
==========================================
+ Coverage   89.82%   90.97%   +1.14%     
==========================================
  Files         412      407       -5     
  Lines       11878    12593     +715     
  Branches     2364     2451      +87     
==========================================
+ Hits        10670    11456     +786     
+ Misses        681      581     -100     
- Partials      527      556      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ScarletKuro ScarletKuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@ScarletKuro ScarletKuro merged commit e571374 into MudBlazor:dev Oct 13, 2024
@ScarletKuro
Copy link
Member

This cause a regression for missing shadow in datepicker #10235

@ScarletKuro
Copy link
Member

Found another regression by this PR.
Arrow tooltips do not show the arrow:
https://dev.mudblazor.com/components/tooltip#arrow-tooltips

@danielchalmers
Copy link
Member Author

Reverted for now. Hard to handle all possible uses. Current recommendation is to apply overflow: hidden yourself if you use border-radius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended regression Previously worked and now doesn't

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments