Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creplaceLine changing order of displayed elements in 3.17 #2300

Closed
PapaGuacamole opened this issue Feb 3, 2019 · 10 comments

Comments

@PapaGuacamole
Copy link
Contributor

commented Feb 3, 2019

Brief summary of issue / Description of requested feature:

creplaceLine seems to be changing the order of elements depending on the colour tags used, eg

Steps to reproduce the issue / Reasons for adding feature:

  1. Exact match trigger: You have recovered balance on all limbs.
  2. code:
    local line = "<black>.<reset> <red>\<\>\<<pink>\>\<<white>\>\<\>\<\>\<\>\<\>\<\>\< BALANCE \>\<\>\<\>\<\>\<\>\<\>\<\>\<<medium_spring_green>//<DarkSeaGreen>====<DeepPink>o<reset>" creplaceLine("\n" .. line .. "\n\n")

Error output / Expected result of feature

display is: ==o==><><><><><>< BALANCE ><><><><><><//>< >< <>< .
(coloured, obviously)

Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:

Using deleteLine() and cecho() displays the output correctly.
There seems to be a related issue with cinsertText, so suggest issue is with new colour functionality....

Windows 10 fully updated
Mudlet 3.17

@vadi2

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

@JorMox would you mind having a look?

@JorMox

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2019

The problem is that getColumnNumber returns 0 when the target window is "main", even when getColumnNumber() returns a different value.

@vadi2

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

Betrayal :(

@SlySven

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

Is that because we have already put in a new line (something about prompt handling) and started a new line when called on the main TConsole?

@TheLastDarkthorne

This comment has been minimized.

Copy link

commented Feb 5, 2019

That is messing up with a lot of echos really, specially from Svof. For example, when there are runes on the ground, they all get mixed up with the room description and the mudlet mapper alertness echos also get weird. Looks like it is affecting cinsertText too.

@JorMox

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

Seems to work for me.

@PapaGuacamole

This comment has been minimized.

Copy link
Contributor Author

commented Feb 5, 2019

Can confirm, working as it did prior to 3.17.0

@vadi2 vadi2 added this to the 3.17.1 milestone Feb 5, 2019

@vadi2 vadi2 closed this Feb 5, 2019

@vadi2

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

Thank you all for reporting and testing!

@druuimai

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2019

im the most badass bug squasher in the world. flexing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.