Adds standard text editor FIND functionality to source editor #3551

dicene · 2020-03-31T01:30:54Z

Brief overview of PR changes/additions

Adds a small Find menu with the shortcut CTRL+F that allows you to search in an individual document quickly, rather than searching the entire profile.

Motivation for adding to Mudlet

Document searching is ubiquitous in code editors. Even though the profile search feature CAN handle searching in the same document, it's not as convenient as being able to CTRL+F then type a search and press enter to immediately hop to the first result, then pressing ENTER or SHIFT+ENTER to go forward and backwards through results. Additionally, many modern IDE's highlight every instance of what you've typed into the search box, giving you an easy way to scroll a script on your own, but with instances of your search made very apparent.

Other info (issues closed, discussion etc)

…lows you to search in an individual document quickly, rather than searching the entire profile.

add-deployment-links · 2020-03-31T01:31:01Z

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

dicene · 2020-03-31T01:36:43Z

Note: There are some comments left in the code that I will remove in a commit, but I wanted to get a functional version up quickly for feedback. Additionally, it's a little hard to see the pre-search outlines with that color-scheme. Here's another screenshot with the Mudlet color scheme. I know it's not accounting for the horizontal scrollbar, I'll fix that in a commit right now.

Edru2 · 2020-03-31T08:59:45Z

Thank you for this! This is very nice. Wanted this for a long time.
👍

I see no way to let the small finder menu disappear,
but I'm sure the functionality is just not added yet.

vadi2 · 2020-03-31T10:20:29Z

Seconded! New files to need to be added to cmake as well, that's why some builds aren't yet passing.

…in the Edbee editor.

dicene · 2020-03-31T16:26:38Z

Thank you for this! This is very nice. Wanted this for a long time.
👍

I see no way to let the small finder menu disappear,
but I'm sure the functionality is just not added yet.

You can manually get rid of it via ESC, with is the standard way of closing those sorts of things in IDE's that I use. Probably a good idea to add a manual close button as well, I'll get on that!

SlySven · 2020-03-31T17:10:49Z

Haven't looked at this one yet, but off the top of my head I thought <F3>/<Shift>+<F3> were the keys for find next / find previous...

SlySven · 2020-03-31T17:17:41Z

src/dlgTriggerEditor.cpp

@@ -8133,6 +8224,11 @@ bool dlgTriggerEditor::event(QEvent* event)
    return QMainWindow::event(event);
 }

+void dlgTriggerEditor::resizeEvent(QResizeEvent* event){


Line-feed before the { please...

Ooh, thought I had caught all the new areas and Beautified. Missed this one!

SlySven · 2020-03-31T17:23:43Z

src/ui/source_editor_find_area.ui

+       <height>0</height>
+      </size>
+     </property>
+     <property name="inputMask">


This, and the next two properties are default aren't they? If so, it is probably safer to trim them out of the .ui file (by hand) to keep them in the defaulted state - (IIRC there is a little reverse icon in the Qt Designer plug-in/ stand-alone utility which might do that (and turn the setting back to the dim default setting) rather than leaving it over-ridden (and thus in bold) but set to the default in that tool...

SlySven · 2020-03-31T17:26:41Z

src/ui/source_editor_find_area.ui

+  <property name="autoFillBackground">
+   <bool>true</bool>
+  </property>
+  <property name="styleSheet">


Be careful - do we really need a style-sheet set on this - as it will interfere with the end-user (or the Desktop Environment) doing so. If it isn't needed I would recommend taking this property out with a bit of editing this file with the plain text editor...

SlySven · 2020-03-31T17:31:05Z

src/ui/source_editor_find_area.ui

+       <verstretch>0</verstretch>
+      </sizepolicy>
+     </property>
+     <property name="text">


You might consider using a symbol (how about the green double triangles ones we use for the searching on the main TConsole) rather than text for this and the next button (though then they will need something for the Qt Accessibility work that is starting up) so that a translation is not needed for normally able users.

SlySven · 2020-04-02T22:40:14Z

🤔 BTW What happens if the main Editor search is used at the same time as this one is active? 😜

SlySven · 2020-04-05T18:45:27Z

Blooming 'eck - something really screwy is happening as a result of that last commit dc2e26d as we get compilation errors about the use of a (publically, so THAT is not the problem) enum defined in the dlgTriggerEditor class but which is not defined at the point it is seen in the Host.h header file - even though that same header HAS the #include "dlgTriggerEditor.h" at the top:

Even adding a class specifier (as I had done in the above screen shot):

     void setPlayerRoomStyleDetails(const quint8 styleCode, const quint8 outerDiameter = 120, const quint8 innerDiameter = 70, const QColor& outerColor = QColor(), const QColor& innerColor = QColor());
     void getPlayerRoomStyleDetails(quint8& styleCode, quint8& outerDiameter, quint8& innerDiameter, QColor& outerColor, QColor& innerColor);
-    void setSearchOptions(const SearchOptions);
+    void setSearchOptions(const dlgTriggerEditor::SearchOptions);

     cTelnet mTelnet;

Doesn't fix it... 😖

dicene · 2020-04-07T13:43:01Z

I really don't enjoy trying to update branches like this to be current with the dev branch. At best, it's an annoyance, at worst things like this happen...

…eSearch" This reverts commit dc2e26d, reversing changes made to 2b53dcd.

vadi2 · 2020-04-07T15:27:57Z

@dicene still need to add the files you've added to cmake - if you could do that that'll fix the rest of the builds :)

…'s suggestions.

dicene · 2020-04-07T15:38:56Z

Running a test build then committing cmake updates right now.

dicene · 2020-04-08T17:31:44Z

Superceded by #3578

Initial commit. Adds small Find menu with the shortcut CTRL+F that al…

a119576

…lows you to search in an individual document quickly, rather than searching the entire profile.

dicene requested review from a team as code owners March 31, 2020 01:30

dicene added 2 commits March 31, 2020 11:49

Updated to move the FindArea when scrollbars are enabled or disabled …

a77e8e5

…in the Edbee editor.

Code cleanup

1fc690b

SlySven reviewed Mar 31, 2020

View reviewed changes

dicene added 3 commits March 31, 2020 13:50

Added close button to find area.

2b5c1b9

Added FindNext and FindPrevious shortcuts. Slight UI change.

2b53dcd

Merge remote-tracking branch 'origin/development' into inEdbeeSearch

dc2e26d

Revert "Merge remote-tracking branch 'origin/development' into inEdbe…

7b3b90c

…eSearch" This reverts commit dc2e26d, reversing changes made to 2b53dcd.

dicene requested a review from a team as a code owner April 7, 2020 15:25

Format fixes. Replaced text with icons. Other small fixes from @SlySven…

69bcbc4

…'s suggestions.

dicene mentioned this pull request Apr 8, 2020

Adds standard text editor FIND functionality to source editor #3578

Merged

dicene closed this Apr 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds standard text editor FIND functionality to source editor #3551

Adds standard text editor FIND functionality to source editor #3551

dicene commented Mar 31, 2020

add-deployment-links bot commented Mar 31, 2020 •

edited

dicene commented Mar 31, 2020

Edru2 commented Mar 31, 2020

vadi2 commented Mar 31, 2020

dicene commented Mar 31, 2020

SlySven commented Mar 31, 2020

SlySven Mar 31, 2020

dicene Mar 31, 2020

SlySven Mar 31, 2020

SlySven Mar 31, 2020

SlySven Mar 31, 2020

SlySven commented Apr 2, 2020 •

edited

SlySven commented Apr 5, 2020

dicene commented Apr 7, 2020

vadi2 commented Apr 7, 2020

dicene commented Apr 7, 2020

dicene commented Apr 8, 2020

Adds standard text editor FIND functionality to source editor #3551

Adds standard text editor FIND functionality to source editor #3551

Conversation

dicene commented Mar 31, 2020

Brief overview of PR changes/additions

Motivation for adding to Mudlet

Other info (issues closed, discussion etc)

add-deployment-links bot commented Mar 31, 2020 • edited

Test versions

dicene commented Mar 31, 2020

Edru2 commented Mar 31, 2020

vadi2 commented Mar 31, 2020

dicene commented Mar 31, 2020

SlySven commented Mar 31, 2020

SlySven Mar 31, 2020

Choose a reason for hiding this comment

dicene Mar 31, 2020

Choose a reason for hiding this comment

SlySven Mar 31, 2020

Choose a reason for hiding this comment

SlySven Mar 31, 2020

Choose a reason for hiding this comment

SlySven Mar 31, 2020

Choose a reason for hiding this comment

SlySven commented Apr 2, 2020 • edited

SlySven commented Apr 5, 2020

dicene commented Apr 7, 2020

vadi2 commented Apr 7, 2020

dicene commented Apr 7, 2020

dicene commented Apr 8, 2020

add-deployment-links bot commented Mar 31, 2020 •

edited

SlySven commented Apr 2, 2020 •

edited