Remove unused PCRE16 flag #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
SlySven
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Yeah, as I mentioned in Discord that dates back to a time when I thought we would have to run the PCRE1 engine twice over the MUD Server output - once in PCRE(8) mode for the Lua UTF-8 encoded sub-system and once in PCRE16 mode for the core C++ QString UTF-16BE encoded part...
As someone else worked out how to avoid that I guess we do not need it after all...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Remove unused PCRE16 flag
Motivation for adding to Mudlet
It was added as part of 52b48a8, but it is still not used two years later, and just lead us on a bit of a wild goose chase. It can always be added back when we'll actually need it!
Other info (issues closed, discussion etc)